From fa800fcc5c22e8dfc7034b34bdb81b4be96b6f05 Mon Sep 17 00:00:00 2001
From: Stephan de Wit <stephan.de.wit@deciso.com>
Date: Wed, 17 Jul 2024 15:17:42 +0200
Subject: [PATCH] dashboard: move async config retrieval out of loop

---
 src/opnsense/www/js/widgets/Traffic.js | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/src/opnsense/www/js/widgets/Traffic.js b/src/opnsense/www/js/widgets/Traffic.js
index 010636c41..5a0666d69 100644
--- a/src/opnsense/www/js/widgets/Traffic.js
+++ b/src/opnsense/www/js/widgets/Traffic.js
@@ -165,14 +165,18 @@ export default class Traffic extends BaseWidget {
             this.initialized = true;
         }
 
+        let config = null;
+        if (this.configChanged) {
+            config = await this.getWidgetConfig();
+        }
+
         for (let chart of Object.values(this.charts)) {
             Object.keys(data.interfaces).forEach((intf) => {
-                chart.config.data.datasets.forEach(async (dataset) => {
+                chart.config.data.datasets.forEach((dataset) => {
                     if (dataset.intf === intf) {
                         let elapsed_time = data.time - dataset.last_time;
                         if (this.configChanged) {
                             // check hidden status of dataset
-                            const config = await this.getWidgetConfig();
                             dataset.hidden = !config.interfaces.includes(data.interfaces[intf].name);
                         }
                         dataset.data.push({