From f98f4e4f1e759558e01975f3d3abd23d7addcfcc Mon Sep 17 00:00:00 2001 From: James Golovich Date: Mon, 16 Aug 2021 10:10:07 -0700 Subject: [PATCH] Allow DNS resolver to skip entry on EmptyLabel (#4560) * Allow DNS resolver to skip entry on EmptyLabel A name like '.example.com' is not a valid name, but should be handled like a non existant name instead of throwing an exception --- src/opnsense/scripts/filter/lib/alias.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/opnsense/scripts/filter/lib/alias.py b/src/opnsense/scripts/filter/lib/alias.py index 7b51f3479..eb2e4d8cb 100755 --- a/src/opnsense/scripts/filter/lib/alias.py +++ b/src/opnsense/scripts/filter/lib/alias.py @@ -132,7 +132,7 @@ class Alias(object): for rdata in self._dnsResolver.query(address, record_type): yield str(rdata) could_resolve = True - except (dns.resolver.NoAnswer, dns.resolver.NXDOMAIN, dns.exception.Timeout, dns.resolver.NoNameservers): + except (dns.resolver.NoAnswer, dns.resolver.NXDOMAIN, dns.exception.Timeout, dns.resolver.NoNameservers, dns.name.EmptyLabel): pass if not could_resolve: