lucaspalomodevelop/core
1
0
Fork 0
mirror of https://github.com/lucaspalomodevelop/core.git synced 2026-03-15 09:04:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

MVC / bootgrid - similar issue as 926a4c8e68 for a couple of MVC components, when POST sends an empty array, we should handle that properly.

Browse Source
This commit is contained in:
Ad Schellevis 2022-12-05 17:56:21 +01:00
parent ae8e0ce4a4
commit f55c828e23
3 changed files with 20 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/FirewallController.php
View File

@ -177,7 +177,11 @@ class FirewallController extends ApiControllerBase
if ($this->request->getPost('searchPhrase', 'string', '') != '') {
$searchPhrase = $filter->sanitize($this->request->getPost('searchPhrase'), 'query');
}
if ($this->request->has('sort') && is_array($this->request->getPost("sort"))) {
if (
$this->request->has('sort') &&
is_array($this->request->getPost("sort")) &&
!empty($this->request->getPost("sort"))
) {
$tmp = array_keys($this->request->getPost("sort"));
$sortBy = $tmp[0] . " " . $this->request->getPost("sort")[$tmp[0]];
}
@ -231,7 +235,11 @@ class FirewallController extends ApiControllerBase
if ($this->request->getPost('searchPhrase', 'string', '') != '') {
$searchPhrase = $filter->sanitize($this->request->getPost('searchPhrase'), 'query');
}
if ($this->request->has('sort') && is_array($this->request->getPost("sort"))) {
if (
$this->request->has('sort') &&
is_array($this->request->getPost("sort")) &&
!empty($this->request->getPost("sort"))
) {
$tmp = array_keys($this->request->getPost("sort"));
$sortBy = $tmp[0] . " " . $this->request->getPost("sort")[$tmp[0]];
}

6
src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/AliasUtilController.php
View File

@ -117,7 +117,11 @@ class AliasUtilController extends ApiControllerBase
return $item;
}, $entry_keys);
if ($this->request->hasPost('sort') && is_array($this->request->getPost('sort'))) {
if (
$this->request->hasPost('sort') &&
is_array($this->request->getPost('sort')) &&
!empty($this->request->getPost('sort'))
) {
$sortcolumn = array_key_first($this->request->getPost('sort'));
$sort_order = $this->request->getPost('sort')[$sortcolumn];
if (!empty(array_column($formatted_full, $sortcolumn))) {

6
src/opnsense/mvc/app/controllers/OPNsense/IDS/Api/SettingsController.php
View File

@ -79,7 +79,11 @@ class SettingsController extends ApiMutableModelControllerBase
$itemsPerPage = $this->request->getPost('rowCount', 'int', 9999);
$currentPage = $this->request->getPost('current', 'int', 1);
if ($this->request->hasPost('sort') && is_array($this->request->getPost("sort"))) {
if (
$this->request->hasPost('sort') &&
is_array($this->request->getPost("sort")) &&
!empty($this->request->getPost("sort"))
) {
$sortStr = '';
$sortBy = array_keys($this->request->getPost("sort"));
if ($this->request->getPost("sort")[$sortBy[0]] == "desc") {