From f394a78f61fbae57df26d04a7d4baf11902f2d02 Mon Sep 17 00:00:00 2001
From: kulikov-a <36099472+kulikov-a@users.noreply.github.com>
Date: Sun, 26 Feb 2023 14:31:07 +0300
Subject: [PATCH] Unbound: typo (#6360)

Type casting in wrong place: may skip updateBlocklist action if model node exists but empty
---
 .../controllers/OPNsense/Unbound/Api/SettingsController.php   | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/opnsense/mvc/app/controllers/OPNsense/Unbound/Api/SettingsController.php b/src/opnsense/mvc/app/controllers/OPNsense/Unbound/Api/SettingsController.php
index 4899526e3..c398907df 100644
--- a/src/opnsense/mvc/app/controllers/OPNsense/Unbound/Api/SettingsController.php
+++ b/src/opnsense/mvc/app/controllers/OPNsense/Unbound/Api/SettingsController.php
@@ -48,7 +48,7 @@ class SettingsController extends ApiMutableModelControllerBase
             $domain = $this->request->getPost('domain');
             $type = $this->request->getPost('type');
             $mdl = $this->getModel();
-            $item = (string)$mdl->getNodeByReference('dnsbl.' . $type);
+            $item = $mdl->getNodeByReference('dnsbl.' . $type);
 
             if ($item != null) {
                 $remove = function ($csv, $part) {
@@ -63,7 +63,7 @@ class SettingsController extends ApiMutableModelControllerBase
                 $wl = explode(',', (string)$mdl->dnsbl->whitelists);
                 $bl = explode(',', (string)$mdl->dnsbl->blocklists);
 
-                $existing_domains = explode(',', $item);
+                $existing_domains = explode(',', (string)$item);
                 if (in_array($value, $existing_domains)) {
                     // value already in model, no need to re-run a potentially
                     // expensive dnsbl action