From f30c28ca79f803fdfab6e90083bbeb3524158946 Mon Sep 17 00:00:00 2001 From: Franco Fichtner Date: Tue, 15 Apr 2025 12:33:53 +0200 Subject: [PATCH] mvc: allow referencing disabled interfaces in LinkAddressField This prevents validation errors when interfaces are temporarily disabled. Other device components received similar fixes in the past due to this "glitch" of not offering valid devices and selectpickers would lose their correct value on save too (the field is a bit different here but the same principle applies). --- .../models/OPNsense/Interfaces/FieldTypes/LinkAddressField.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/opnsense/mvc/app/models/OPNsense/Interfaces/FieldTypes/LinkAddressField.php b/src/opnsense/mvc/app/models/OPNsense/Interfaces/FieldTypes/LinkAddressField.php index f813d7776..8ffa7c5cf 100644 --- a/src/opnsense/mvc/app/models/OPNsense/Interfaces/FieldTypes/LinkAddressField.php +++ b/src/opnsense/mvc/app/models/OPNsense/Interfaces/FieldTypes/LinkAddressField.php @@ -53,7 +53,7 @@ class LinkAddressField extends BaseField self::$option_groups['ipalias'] = ['items' => [], 'title' => gettext('IP Alias')]; foreach ($cfg->interfaces->children() as $ifname => $node) { $descr = !empty((string)$node->descr) ? (string)$node->descr : strtoupper($ifname); - if (!empty((string)$node->virtual) || empty((string)$node->enable)) { + if (!empty((string)$node->virtual)) { continue; } self::$known_addresses[$ifname] = $descr;