From f10604cda7bd5124e24ab3fea2f5bfd17c6974b9 Mon Sep 17 00:00:00 2001
From: Franco Fichtner <franco@opnsense.org>
Date: Tue, 17 Sep 2024 08:27:48 +0200
Subject: [PATCH] interfaces: straighten out VIP status ACLs

---
 .../OPNsense/Diagnostics/Api/InterfaceController.php          | 2 +-
 src/opnsense/mvc/app/models/OPNsense/Interfaces/ACL/ACL.xml   | 4 ++--
 src/opnsense/mvc/app/views/OPNsense/Diagnostics/vip.volt      | 4 ++--
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/InterfaceController.php b/src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/InterfaceController.php
index f0f51fe20..6de305d53 100644
--- a/src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/InterfaceController.php
+++ b/src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/InterfaceController.php
@@ -367,7 +367,7 @@ class InterfaceController extends ApiControllerBase
         return array("message" => "error");
     }
 
-    public function getPfSyncNodesAction()
+    public function getPfsyncNodesAction()
     {
         $records = json_decode((new Backend())->configdRun("filter list pfsync json"), true) ?? [];
         $records = !empty($records['nodes']) ? $records['nodes'] : [];
diff --git a/src/opnsense/mvc/app/models/OPNsense/Interfaces/ACL/ACL.xml b/src/opnsense/mvc/app/models/OPNsense/Interfaces/ACL/ACL.xml
index 6f5038da3..69e1af30f 100644
--- a/src/opnsense/mvc/app/models/OPNsense/Interfaces/ACL/ACL.xml
+++ b/src/opnsense/mvc/app/models/OPNsense/Interfaces/ACL/ACL.xml
@@ -11,8 +11,8 @@
         <patterns>
             <pattern>ui/diagnostics/interface/vip</pattern>
             <pattern>api/diagnostics/interface/carp_status</pattern>
-            <pattern>api/diagnostics/interface/get_vip_status/*</pattern>
-            <pattern>api/diagnostics/interface/get_pfsync_nodes/*</pattern>
+            <pattern>api/diagnostics/interface/get_vip_status</pattern>
+            <pattern>api/diagnostics/interface/get_pfsync_nodes</pattern>
         </patterns>
     </page-status-carp>
     <page-interfaces-vxlan>
diff --git a/src/opnsense/mvc/app/views/OPNsense/Diagnostics/vip.volt b/src/opnsense/mvc/app/views/OPNsense/Diagnostics/vip.volt
index 808da327b..a9ca109cf 100644
--- a/src/opnsense/mvc/app/views/OPNsense/Diagnostics/vip.volt
+++ b/src/opnsense/mvc/app/views/OPNsense/Diagnostics/vip.volt
@@ -1,7 +1,7 @@
 <script>
     $( document ).ready(function() {
         $("#grid-vips").UIBootgrid({
-          search:'/api/diagnostics/interface/get_vip_status/',
+          search:'/api/diagnostics/interface/get_vip_status',
           options:{
               requestHandler: function(request){
                   if ( $('#mode_filter').val().length > 0) {
@@ -55,7 +55,7 @@
           }
         });
         $("#grid-pfsyncnodes").UIBootgrid({
-          search:'/api/diagnostics/interface/get_pfsync_nodes/',
+          search:'/api/diagnostics/interface/get_pfsync_nodes',
         });
         $("#mode_filter").change(function(){
             $('#grid-vips').bootgrid('reload');