From ef5a59f5e4e984a94ea02d38b6adb35f5bc7dc89 Mon Sep 17 00:00:00 2001
From: Franco Fichtner <franco@opnsense.org>
Date: Wed, 14 Aug 2024 14:49:27 +0200
Subject: [PATCH] firmware: add upgrade test, maybe later also a size check;
 closes #7769

---
 src/etc/rc.syshook.d/upgrade/10-sanity.sh | 17 +++++++++++++++++
 src/opnsense/scripts/firmware/health.sh   |  5 +++++
 2 files changed, 22 insertions(+)
 create mode 100755 src/etc/rc.syshook.d/upgrade/10-sanity.sh

diff --git a/src/etc/rc.syshook.d/upgrade/10-sanity.sh b/src/etc/rc.syshook.d/upgrade/10-sanity.sh
new file mode 100755
index 000000000..506153789
--- /dev/null
+++ b/src/etc/rc.syshook.d/upgrade/10-sanity.sh
@@ -0,0 +1,17 @@
+#!/bin/sh
+
+CORE=$(opnsense-version -n)
+
+if [ -z "${CORE}" ]; then
+	echo "Could not determine core package name."
+	exit 1
+fi
+
+if [ -z "$(pkg query %n ${CORE})" ]; then
+	echo "Core package \"${CORE}\" not known to package database."
+	exit 1
+fi
+
+echo "Passed all upgrade tests."
+
+exit 0
diff --git a/src/opnsense/scripts/firmware/health.sh b/src/opnsense/scripts/firmware/health.sh
index cd84fbb7b..d885cb97d 100755
--- a/src/opnsense/scripts/firmware/health.sh
+++ b/src/opnsense/scripts/firmware/health.sh
@@ -126,6 +126,11 @@ core_check()
 	CORE=$(opnsense-version -n)
 	PROGRESS=
 
+	if [ -z "${CORE}" ]; then
+		echo "Could not determine core package name."
+		return
+	fi
+
 	if [ -z "$(pkg query %n ${CORE})" ]; then
 		echo "Core package \"${CORE}\" not known to package database." | ${TEE} ${LOCKFILE}
 		return