From ee0e0eaeed96d2b28b9e8cf00eebbfd7e2d028e7 Mon Sep 17 00:00:00 2001 From: Franco Fichtner Date: Sun, 12 Feb 2017 19:33:46 +0100 Subject: [PATCH] firewall: improve validation on previous --- src/www/firewall_rules_edit.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/www/firewall_rules_edit.php b/src/www/firewall_rules_edit.php index 8235f530f..c5bf6959e 100644 --- a/src/www/firewall_rules_edit.php +++ b/src/www/firewall_rules_edit.php @@ -387,15 +387,15 @@ if ($_SERVER['REQUEST_METHOD'] === 'GET') { $input_errors[] = gettext("If you specify TCP flags that should be set you should specify out of which flags as well."); - if (!empty($pconfig['set-prio']) && (!is_numericint($pconfig['set-prio']) || $pconfig['set-prio'] < 0 || $pconfig['set-prio'] > 7)) { + if (isset($pconfig['set-prio']) && $pconfig['set-prio'] !== '' && (!is_numericint($pconfig['set-prio']) || $pconfig['set-prio'] < 0 || $pconfig['set-prio'] > 7)) { $input_errors[] = gettext('Set priority must be an integer between 0 and 7.'); } - if (!empty($pconfig['set-prio-low']) && (!is_numericint($pconfig['set-prio-low']) || $pconfig['set-prio-low'] < 0 || $pconfig['set-prio-low'] > 7)) { + if (isset($pconfig['set-prio-low']) && $pconfig['set-prio-low'] !== '' && (!is_numericint($pconfig['set-prio-low']) || $pconfig['set-prio-low'] < 0 || $pconfig['set-prio-low'] > 7)) { $input_errors[] = gettext('Set priority for low latency and acknowledgements must be an integer between 0 and 7.'); } - if (empty($pconfig['set-prio']) && !empty($pconfig['set-prio-low'])) { + if (isset($pconfig['set-prio-low']) && $pconfig['set-prio-low'] !== '' && (!isset($pconfig['set-prio']) || $pconfig['set-prio'] === '')) { $input_errors[] = gettext('Set priority for low latency and acknowledgements requires a set priority for normal packets.'); }