From edd0d25423c8d531d99248d16e8e5191efd202eb Mon Sep 17 00:00:00 2001
From: Franco Fichtner <franco@opnsense.org>
Date: Thu, 13 Oct 2022 11:03:33 +0200
Subject: [PATCH] firewall: off-by-one in regex for target port range parse

PR: https://forum.opnsense.org/index.php?topic=30652.0
---
 src/www/firewall_nat.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/www/firewall_nat.php b/src/www/firewall_nat.php
index f4756decf..d0ce3feb5 100644
--- a/src/www/firewall_nat.php
+++ b/src/www/firewall_nat.php
@@ -489,7 +489,7 @@ $( document ).ready(function() {
 <?php
                          $localport = $natent['local-port'];
                          if (strpos($natent['destination']['port'],'-') !== false) {
-                            $natlocalport = preg_match('/^(\d){1,4}$/', $natent['local-port']) ? (int)$natent['local-port'] : 1;
+                            $natlocalport = preg_match('/^(\d){1,5}$/', $natent['local-port']) ? (int)$natent['local-port'] : 1;
                             list($dstbeginport, $dstendport) = explode("-", $natent['destination']['port']);
                             $dstbeginport = preg_match('/^\d*$/', $dstbeginport) ? (int)$dstbeginport : 1;
                             $dstendport = preg_match('/^\d*$/', $dstendport) ? (int)$dstendport : 65535;