src: undo change to edge case in Local TOTP #2390

TOTP modifies password, we can't use verbatim length checks.

Spotted by: @adschellevis

src/opnsense/mvc/app/library/OPNsense/Auth/Local.php

@@ -106,7 +106,10 @@ class Local extends Base implements IAuthConnector
     }
 
     /**
-     * check if the user should change his or hers password, calculated by the time difference of the last pwd change
+     * check if the user should change his or hers password,
+     * calculated by the time difference of the last pwd change
+     * and other criteria through checkPolicy() if password was
+     * given
      * @param string $username username to check
      */
     public function shouldChangePassword($username, $password = null)

src/opnsense/mvc/app/library/OPNsense/Auth/TOTP.php

@@ -173,6 +173,16 @@ trait TOTP
         return false;
     }
 
+    /**
+     * check if the user should change his or hers password
+     * @param string $username username to check
+     */
+    public function shouldChangePassword($username, $password = null)
+    {
+        /* XXX deconstruct password and pass it */
+        return parent::shouldChangePassword($username);
+    }
+
     /**
      * set TOTP specific connector properties
      * @param array $config connection properties