diff --git a/src/etc/inc/plugins.inc.d/unbound.inc b/src/etc/inc/plugins.inc.d/unbound.inc index 94d881784..23698653d 100644 --- a/src/etc/inc/plugins.inc.d/unbound.inc +++ b/src/etc/inc/plugins.inc.d/unbound.inc @@ -255,10 +255,13 @@ EOF; $include_dhcpleases = ''; } + $unbound_mdl = new \OPNsense\Unbound\Unbound(); + $unbound_enabled = (string)$unbound_mdl->forwarding->enabled; + $forward_conf = ''; $forward_local = ''; $resolv_conf_root = ''; - if (isset($config['unbound']['forwarding'])) { + if ($unbound_enabled) { $dnsservers = get_nameservers(); if (!empty($dnsservers)) { diff --git a/src/opnsense/mvc/app/controllers/OPNsense/Unbound/Api/SettingsController.php b/src/opnsense/mvc/app/controllers/OPNsense/Unbound/Api/SettingsController.php index 3051f7939..226d8592e 100644 --- a/src/opnsense/mvc/app/controllers/OPNsense/Unbound/Api/SettingsController.php +++ b/src/opnsense/mvc/app/controllers/OPNsense/Unbound/Api/SettingsController.php @@ -40,37 +40,6 @@ class SettingsController extends ApiMutableModelControllerBase private $type = 'dot'; - public function toggleSystemForwardAction() - { - if ($this->request->isPost() && $this->request->hasPost('forwarding')) { - $this->sessionClose(); - Config::getInstance()->lock(); - $config = Config::getInstance()->object(); - - $val = $this->request->getPost('forwarding')['enabled']; - - /* Write to config exactly as legacy would */ - $config->unbound->forwarding = !empty($val); - if ($val != "1") { - /* legacy uses isset() */ - unset($config->unbound->forwarding); - } - - /* save and release lock */ - Config::getInstance()->save(); - } - } - - public function getSystemForwardAction() - { - $config = Config::getInstance()->object(); - return array("forwarding" => - array( "enabled" => - empty($config->unbound->forwarding) ? 0 : 1 - ) - ); - } - public function getNameserversAction() { if ($this->request->isGet()) { diff --git a/src/opnsense/mvc/app/controllers/OPNsense/Unbound/forms/forwarding.xml b/src/opnsense/mvc/app/controllers/OPNsense/Unbound/forms/forwarding.xml index c40ece719..03786bac6 100755 --- a/src/opnsense/mvc/app/controllers/OPNsense/Unbound/forms/forwarding.xml +++ b/src/opnsense/mvc/app/controllers/OPNsense/Unbound/forms/forwarding.xml @@ -1,6 +1,6 @@
- forwarding.enabled + unbound.forwarding.enabled checkbox @@ -11,7 +11,7 @@ - forwarding.info + unbound.forwarding.info info diff --git a/src/opnsense/mvc/app/models/OPNsense/Unbound/Migrations/M1_0_2.php b/src/opnsense/mvc/app/models/OPNsense/Unbound/Migrations/M1_0_2.php index 3348612a2..b014ccc4f 100755 --- a/src/opnsense/mvc/app/models/OPNsense/Unbound/Migrations/M1_0_2.php +++ b/src/opnsense/mvc/app/models/OPNsense/Unbound/Migrations/M1_0_2.php @@ -51,5 +51,10 @@ class M1_0_2 extends BaseModelMigration $dot->type = "dot"; } } + + if (isset($config->unbound->forwarding)) { + $model->forwarding->enabled = "1"; + unset($config->unbound->forwarding); + } } } diff --git a/src/opnsense/mvc/app/models/OPNsense/Unbound/Unbound.xml b/src/opnsense/mvc/app/models/OPNsense/Unbound/Unbound.xml index 357c53da9..3f758b564 100644 --- a/src/opnsense/mvc/app/models/OPNsense/Unbound/Unbound.xml +++ b/src/opnsense/mvc/app/models/OPNsense/Unbound/Unbound.xml @@ -57,8 +57,9 @@ - - unbound.forwarding + + 0 + N diff --git a/src/opnsense/mvc/app/views/OPNsense/Unbound/dot.volt b/src/opnsense/mvc/app/views/OPNsense/Unbound/dot.volt index ca036bf54..a7e75d002 100644 --- a/src/opnsense/mvc/app/views/OPNsense/Unbound/dot.volt +++ b/src/opnsense/mvc/app/views/OPNsense/Unbound/dot.volt @@ -27,45 +27,45 @@