From eb7c62b605fd949e2a5e7e3585bdada1918b764c Mon Sep 17 00:00:00 2001 From: Ad Schellevis Date: Mon, 15 Jun 2020 13:53:13 +0200 Subject: [PATCH] firewall/VIPs, config_read_array() adding an empty lo0. closes https://github.com/opnsense/core/issues/4170 --- src/www/firewall_virtual_ip_edit.php | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/www/firewall_virtual_ip_edit.php b/src/www/firewall_virtual_ip_edit.php index 5e3e3cdb8..4f836c419 100644 --- a/src/www/firewall_virtual_ip_edit.php +++ b/src/www/firewall_virtual_ip_edit.php @@ -89,9 +89,11 @@ if ($_SERVER['REQUEST_METHOD'] === 'GET') { if (isset($pconfig['id']) && isset($a_vip[$pconfig['id']])) { $id = $pconfig['id']; } - $selected_interface = config_read_array('interfaces', $pconfig['interface']); - $selected_interface = !empty($selected_interface) ? $selected_interface['if'] : $pconfig['interface'] ; - + if (!empty($config['interfaces'][$pconfig['interface']]) && !empty($config['interfaces'][$pconfig['interface']]['if'])) { + $selected_interface = $config['interfaces'][$pconfig['interface']]['if']; + } else { + $selected_interface = array(); + } // perform form validations $reqdfields = array("mode"); $reqdfieldsn = array(gettext("Type"));