From e43bca743b36f3bd2e04abba4a3bd3cca7b17595 Mon Sep 17 00:00:00 2001
From: Ad Schellevis <ad@opnsense.org>
Date: Thu, 23 Jan 2025 13:38:52 +0100
Subject: [PATCH] Services: Unbound DNS - flag overwrites when they exists
 (https://docs.opnsense.org/manual/unbound.html#advanced-configurations)

---
 plist                                         |  1 +
 .../System/Status/UnboundOverrideStatus.php   | 65 +++++++++++++++++++
 2 files changed, 66 insertions(+)
 create mode 100644 src/opnsense/mvc/app/library/OPNsense/System/Status/UnboundOverrideStatus.php

diff --git a/plist b/plist
index db3eaa76e..745652b0e 100644
--- a/plist
+++ b/plist
@@ -578,6 +578,7 @@
 /usr/local/opnsense/mvc/app/library/OPNsense/System/Status/LiveMediaStatus.php
 /usr/local/opnsense/mvc/app/library/OPNsense/System/Status/OpensshOverrideStatus.php
 /usr/local/opnsense/mvc/app/library/OPNsense/System/Status/SystemBootingStatus.php
+/usr/local/opnsense/mvc/app/library/OPNsense/System/Status/UnboundOverrideStatus.php
 /usr/local/opnsense/mvc/app/library/OPNsense/System/SystemStatus.php
 /usr/local/opnsense/mvc/app/library/OPNsense/System/SystemStatusCode.php
 /usr/local/opnsense/mvc/app/library/OPNsense/Trust/Store.php
diff --git a/src/opnsense/mvc/app/library/OPNsense/System/Status/UnboundOverrideStatus.php b/src/opnsense/mvc/app/library/OPNsense/System/Status/UnboundOverrideStatus.php
new file mode 100644
index 000000000..4f90d4c4e
--- /dev/null
+++ b/src/opnsense/mvc/app/library/OPNsense/System/Status/UnboundOverrideStatus.php
@@ -0,0 +1,65 @@
+<?php
+
+/*
+ * Copyright (C) 2025 Deciso B.V.
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are met:
+ *
+ * 1. Redistributions of source code must retain the above copyright notice,
+ *    this list of conditions and the following disclaimer.
+ *
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *    notice, this list of conditions and the following disclaimer in the
+ *    documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES,
+ * INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY
+ * AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
+ * AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY,
+ * OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+ * POSSIBILITY OF SUCH DAMAGE.
+ */
+
+namespace OPNsense\System\Status;
+
+use OPNsense\System\AbstractStatus;
+use OPNsense\System\SystemStatusCode;
+
+class UnboundOverrideStatus extends AbstractStatus
+{
+    public function __construct()
+    {
+        $this->internalPriority = 2;
+        $this->internalPersistent = true;
+        $this->internalTitle = gettext('Configuration override');
+        $this->internalIsBanner = true;
+        $this->internalScope[] = '/ui/unbound/*';
+    }
+
+    public function collectStatus()
+    {
+        /* XXX: custom overwrites don't live in their own path, which makes detection less practical */
+        $managed_files = [];
+        $tmp = @file_get_contents('/usr/local/opnsense/service/templates/OPNsense/Unbound/core/+TARGETS') ?? '';
+        foreach (explode("\n", $tmp) as $line) {
+            if (strpos($line, 'unbound.opnsense.d') > 1) {
+                $managed_files[] = trim(explode(":", $line)[1]);
+            }
+        }
+        foreach (glob('/usr/local/etc/unbound.opnsense.d/*.conf') as $filename) {
+            if (!in_array($filename, $managed_files)) {
+                $this->internalMessage = gettext(
+                    'The configuration contains manual overwrites, these may interfere with the settings configured here.'
+                );
+                $this->internalStatus = SystemStatusCode::NOTICE;
+                break;
+            }
+        }
+    }
+}