From e23fee9ec7c1449bc64cbe9e29cc7e0aa58bc5cf Mon Sep 17 00:00:00 2001 From: Stephan de Wit Date: Mon, 25 Mar 2024 16:44:11 +0100 Subject: [PATCH] mvc: configdStream: actually, ob_end_flush() is still necessary Turns out there is still implicit buffering happening, the exception thrown is due to a lack of error handling on the Phalcon side. Even the PHP docs suggest silencing this with '@'. This reverts commit 7c05e524b047e6d915b80994855a4e69d365645c. --- .../mvc/app/controllers/OPNsense/Base/ApiControllerBase.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/opnsense/mvc/app/controllers/OPNsense/Base/ApiControllerBase.php b/src/opnsense/mvc/app/controllers/OPNsense/Base/ApiControllerBase.php index 42729c609..622512fb0 100644 --- a/src/opnsense/mvc/app/controllers/OPNsense/Base/ApiControllerBase.php +++ b/src/opnsense/mvc/app/controllers/OPNsense/Base/ApiControllerBase.php @@ -180,7 +180,7 @@ class ApiControllerBase extends ControllerRoot foreach ($headers as $header) { header($header); } - + ob_end_flush(); fpassthru($response); }