From de8210ba120d010bf29c792d8aaefda61a065c25 Mon Sep 17 00:00:00 2001
From: Ad Schellevis <ad@opnsense.org>
Date: Thu, 26 Sep 2024 11:02:47 +0200
Subject: [PATCH] Services: Kea DHCP: Kea DHCPv4 - add configurable
 max-unacked-clients parameter and change default to 2 to make it more
 responsive. closes https://github.com/opnsense/core/issues/7458

---
 .../OPNsense/Kea/forms/generalSettings4.xml            | 10 ++++++++++
 src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv4.php |  2 +-
 src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv4.xml |  8 +++++++-
 3 files changed, 18 insertions(+), 2 deletions(-)

diff --git a/src/opnsense/mvc/app/controllers/OPNsense/Kea/forms/generalSettings4.xml b/src/opnsense/mvc/app/controllers/OPNsense/Kea/forms/generalSettings4.xml
index e2c82fe9f..40c3f5d5d 100644
--- a/src/opnsense/mvc/app/controllers/OPNsense/Kea/forms/generalSettings4.xml
+++ b/src/opnsense/mvc/app/controllers/OPNsense/Kea/forms/generalSettings4.xml
@@ -45,4 +45,14 @@
         Leave empty to use this machines hostname
         </help>
     </field>
+    <field>
+        <id>dhcpv4.ha.max_unacked_clients</id>
+        <label>Max Unacked clients</label>
+        <type>text</type>
+        <help>
+        This specifies the number of clients which send messages to the partner but appear to not receive any response.
+        A higher value needs a busier environment in order to consider a member down, when set to 0,
+        any network disruption will cause a failover to happen.
+        </help>
+    </field>
 </form>
diff --git a/src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv4.php b/src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv4.php
index 7e1bfed72..e8435cbe5 100644
--- a/src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv4.php
+++ b/src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv4.php
@@ -229,7 +229,7 @@ class KeaDhcpv4 extends BaseModel
                                 'heartbeat-delay' => 10000,
                                 'max-response-delay' => 60000,
                                 'max-ack-delay' => 5000,
-                                'max-unacked-clients' => 5,
+                                'max-unacked-clients' => (int)((string)$this->ha->max_unacked_clients),
                                 'sync-timeout' => 60000,
                             ]
                         ]
diff --git a/src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv4.xml b/src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv4.xml
index dd7264e2e..85f77e973 100644
--- a/src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv4.xml
+++ b/src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv4.xml
@@ -25,9 +25,15 @@
                 <Default>0</Default>
                 <Required>Y</Required>
             </enabled>
-            <this_server_name  type="TextField">
+            <this_server_name type="TextField">
                 <Mask>/^([0-9a-zA-Z.\:\-,_]){0,1024}$/u</Mask>
             </this_server_name>
+            <max_unacked_clients type="IntegerField">
+                <MinimumValue>0</MinimumValue>
+                <MaximumValue>65535</MaximumValue>
+                <Default>2</Default>
+                <Required>Y</Required>
+            </max_unacked_clients>
         </ha>
         <subnets>
             <subnet4 type="ArrayField">