From db2bcf716e0b7e8b1809de1d9a53322b208243cc Mon Sep 17 00:00:00 2001 From: Franco Fichtner Date: Thu, 12 Jan 2023 10:00:14 +0100 Subject: [PATCH] interfaces: ifconfig doesn't like reordering, should have been tested --- src/etc/inc/interfaces.lib.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/etc/inc/interfaces.lib.inc b/src/etc/inc/interfaces.lib.inc index 31a543527..182054350 100644 --- a/src/etc/inc/interfaces.lib.inc +++ b/src/etc/inc/interfaces.lib.inc @@ -166,7 +166,7 @@ function legacy_bridge_member($ifs, $member) function legacy_vlan_tag($ifs, $member, $tag, $pcp, $proto) { - $cmd = '/sbin/ifconfig ' . escapeshellarg($ifs) . ' vlandev ' . escapeshellarg($member) . ' vlan ' . escapeshellarg($tag) . ' vlanpcp ' . escapeshellarg($pcp) . ' vlanproto ' . escapeshellarg($proto); + $cmd = '/sbin/ifconfig ' . escapeshellarg($ifs) . ' vlan ' . escapeshellarg($tag) . ' vlandev ' . escapeshellarg($member) . ' vlanpcp ' . escapeshellarg($pcp) . ' vlanproto ' . escapeshellarg($proto); exec($cmd . ' 2>&1', $out, $ret); if ($ret) {