From fa142b553669b317b8d5d920b049736cc222e868 Mon Sep 17 00:00:00 2001 From: Manuel Faux Date: Thu, 7 Jan 2016 17:06:38 +0100 Subject: [PATCH 1/2] UX: Changed icon for "add similar item" Changed button icon of "add similar item" from plus to clone symbol. --- src/www/firewall_nat.php | 2 +- src/www/firewall_nat_1to1.php | 2 +- src/www/firewall_nat_npt.php | 2 +- src/www/firewall_nat_out.php | 2 +- src/www/firewall_rules.php | 2 +- src/www/firewall_schedule.php | 2 +- src/www/firewall_virtual_ip.php | 2 +- src/www/system_gateway_groups.php | 2 +- src/www/system_gateways.php | 2 +- src/www/system_routes.php | 2 +- src/www/vpn_ipsec.php | 4 ++-- 11 files changed, 12 insertions(+), 12 deletions(-) diff --git a/src/www/firewall_nat.php b/src/www/firewall_nat.php index d99f9340d..1159fe48c 100644 --- a/src/www/firewall_nat.php +++ b/src/www/firewall_nat.php @@ -381,7 +381,7 @@ $( document ).ready(function() { "> - + diff --git a/src/www/firewall_nat_1to1.php b/src/www/firewall_nat_1to1.php index 802eb12e1..a64ae57cb 100644 --- a/src/www/firewall_nat_1to1.php +++ b/src/www/firewall_nat_1to1.php @@ -251,7 +251,7 @@ $main_buttons = array( " class="btn btn-default btn-xs"> - + diff --git a/src/www/firewall_nat_npt.php b/src/www/firewall_nat_npt.php index db224fb20..c9b280b19 100644 --- a/src/www/firewall_nat_npt.php +++ b/src/www/firewall_nat_npt.php @@ -242,7 +242,7 @@ $main_buttons = array( "> - + diff --git a/src/www/firewall_nat_out.php b/src/www/firewall_nat_out.php index 00055b190..682641dff 100644 --- a/src/www/firewall_nat_out.php +++ b/src/www/firewall_nat_out.php @@ -420,7 +420,7 @@ include("head.inc"); "> - + diff --git a/src/www/firewall_rules.php b/src/www/firewall_rules.php index fa726afda..76e87f563 100644 --- a/src/www/firewall_rules.php +++ b/src/www/firewall_rules.php @@ -532,7 +532,7 @@ $( document ).ready(function() { "> - + diff --git a/src/www/firewall_schedule.php b/src/www/firewall_schedule.php index 227e4ddf6..909717c98 100644 --- a/src/www/firewall_schedule.php +++ b/src/www/firewall_schedule.php @@ -239,7 +239,7 @@ $main_buttons = array( "> - + diff --git a/src/www/firewall_virtual_ip.php b/src/www/firewall_virtual_ip.php index 84b5a39b1..a587497a8 100644 --- a/src/www/firewall_virtual_ip.php +++ b/src/www/firewall_virtual_ip.php @@ -316,7 +316,7 @@ $main_buttons = array( "> - + diff --git a/src/www/system_gateway_groups.php b/src/www/system_gateway_groups.php index 6e662bbee..442375c67 100644 --- a/src/www/system_gateway_groups.php +++ b/src/www/system_gateway_groups.php @@ -200,7 +200,7 @@ $( document ).ready(function() { data-id="" title="" data-toggle="tooltip" data-placement="left" > - + "> - + diff --git a/src/www/system_routes.php b/src/www/system_routes.php index 7016562a7..3cc9a8896 100644 --- a/src/www/system_routes.php +++ b/src/www/system_routes.php @@ -283,7 +283,7 @@ endif; ?> data-placement="left" > - " alt="duplicate"> + " alt="duplicate"> diff --git a/src/www/vpn_ipsec.php b/src/www/vpn_ipsec.php index 98d203b8a..8096fa5f4 100644 --- a/src/www/vpn_ipsec.php +++ b/src/www/vpn_ipsec.php @@ -381,7 +381,7 @@ if (!empty($ph1ent['encryption-algorithm']['keylen'])) { ?> " class="btn btn-default btn-xs" alt="add"> - + @@ -506,7 +506,7 @@ if (!empty($ph2ent['hash-algorithm-option']) && is_array($ph2ent['hash-algorithm " alt="add" class="btn btn-default btn-xs"> - + From 418c800dabe8329548efca102e9cb2740f31f486 Mon Sep 17 00:00:00 2001 From: Manuel Faux Date: Fri, 8 Jan 2016 00:01:38 +0100 Subject: [PATCH 2/2] UX: added missing and unified existing tooltips of buttons * Added missing tooltips for existing buttons for list management (add line, remove line, move line, clone line) * Shortened existing tooltip texts to a minimum * Fixed incorrect tooltip texts * Changed order of buttons to 1. move item, 2. delete item, 3. add item, 4. clone item * Changed tooltips "click to toggle enable/disable rule" to "disable rule" and "enable rule" corresponding to the current state, respectively. --- src/www/firewall_nat.php | 8 ++-- src/www/firewall_nat_1to1.php | 27 +++++++----- src/www/firewall_nat_npt.php | 8 ++-- src/www/firewall_nat_out.php | 14 +++---- src/www/firewall_rules.php | 18 ++++---- src/www/firewall_schedule.php | 6 +-- src/www/firewall_virtual_ip.php | 12 +++--- src/www/system_gateway_groups.php | 10 ++++- src/www/system_gateways.php | 12 +++--- src/www/system_routes.php | 24 ++++++----- src/www/vpn_ipsec.php | 69 +++++++++++++++++-------------- 11 files changed, 113 insertions(+), 95 deletions(-) diff --git a/src/www/firewall_nat.php b/src/www/firewall_nat.php index 1159fe48c..ea13cb064 100644 --- a/src/www/firewall_nat.php +++ b/src/www/firewall_nat.php @@ -303,7 +303,7 @@ $( document ).ready(function() { - "> + "> @@ -374,13 +374,13 @@ $( document ).ready(function() { " class="act_move btn btn-default btn-xs"> - " class="btn btn-default btn-xs"> + " class="btn btn-default btn-xs"> - " data-toggle="tooltip" class="act_delete btn btn-default btn-xs"> + " data-toggle="tooltip" class="act_delete btn btn-default btn-xs"> - "> + "> diff --git a/src/www/firewall_nat_1to1.php b/src/www/firewall_nat_1to1.php index a64ae57cb..6c1789a92 100644 --- a/src/www/firewall_nat_1to1.php +++ b/src/www/firewall_nat_1to1.php @@ -135,7 +135,7 @@ $main_buttons = array( BootstrapDialog.show({ type:BootstrapDialog.TYPE_DANGER, title: "", - message: "", + message: "", buttons: [{ label: "", action: function(dialogRef) { @@ -213,7 +213,12 @@ $main_buttons = array( - " class="act_toggle glyphicon glyphicon glyphicon-play "> + " class="act_toggle"> + + + + + @@ -241,16 +246,16 @@ $main_buttons = array(   - " class="act_move btn btn-default btn-xs"> + " class="act_move btn btn-default btn-xs"> - "> + "> - " data-toggle="tooltip" class="act_delete btn btn-default btn-xs"> + " data-toggle="tooltip" class="act_delete btn btn-default btn-xs"> - " class="btn btn-default btn-xs"> + " class="btn btn-default btn-xs"> @@ -264,30 +269,30 @@ $main_buttons = array( - " class="btn btn-default btn-xs"> + " class="btn btn-default btn-xs"> - " class="act_move btn btn-default btn-xs"> + " class="act_move btn btn-default btn-xs"> - " data-toggle="tooltip" class="btn btn-default btn-xs"> + " data-toggle="tooltip" class="btn btn-default btn-xs"> - " data-toggle="tooltip" class="act_delete btn btn-default btn-xs"> + " data-toggle="tooltip" class="act_delete btn btn-default btn-xs"> - " class="btn btn-default btn-xs"> + " class="btn btn-default btn-xs"> diff --git a/src/www/firewall_nat_npt.php b/src/www/firewall_nat_npt.php index c9b280b19..746ac2dcb 100644 --- a/src/www/firewall_nat_npt.php +++ b/src/www/firewall_nat_npt.php @@ -211,7 +211,7 @@ $main_buttons = array( - "> + "> @@ -235,13 +235,13 @@ $main_buttons = array( " class="act_move btn btn-default btn-xs"> - " class="btn btn-default btn-xs"> + " class="btn btn-default btn-xs"> - " data-toggle="tooltip" class="act_delete btn btn-default btn-xs"> + " data-toggle="tooltip" class="act_delete btn btn-default btn-xs"> - "> + "> diff --git a/src/www/firewall_nat_out.php b/src/www/firewall_nat_out.php index 682641dff..9f9ec9193 100644 --- a/src/www/firewall_nat_out.php +++ b/src/www/firewall_nat_out.php @@ -319,7 +319,7 @@ include("head.inc");
- + @@ -348,11 +348,11 @@ include("head.inc"); - " class="glyphicon glyphicon-play "> + " class="glyphicon glyphicon-play "> - " class="btn btn-default btn-xs "> + " class="btn btn-default btn-xs "> "> " name="move__x" data-toggle="tooltip" data-placement="left" title="" class="act_move btn btn-default btn-xs"> - " class="btn btn-default btn-xs"> + " class="btn btn-default btn-xs"> - " data-toggle="tooltip" class="act_delete btn btn-default btn-xs"> + " data-toggle="tooltip" class="act_delete btn btn-default btn-xs"> - "> + "> @@ -459,7 +459,7 @@ include("head.inc"); - " alt="add" class="btn btn-default btn-xs"> + " alt="add" class="btn btn-default btn-xs"> diff --git a/src/www/firewall_rules.php b/src/www/firewall_rules.php index 76e87f563..610462f66 100644 --- a/src/www/firewall_rules.php +++ b/src/www/firewall_rules.php @@ -290,7 +290,7 @@ $( document ).ready(function() {    " /> diff --git a/src/www/firewall_schedule.php b/src/www/firewall_schedule.php index 909717c98..2118e587d 100644 --- a/src/www/firewall_schedule.php +++ b/src/www/firewall_schedule.php @@ -232,13 +232,13 @@ $main_buttons = array( diff --git a/src/www/firewall_virtual_ip.php b/src/www/firewall_virtual_ip.php index a587497a8..fbfd03b4e 100644 --- a/src/www/firewall_virtual_ip.php +++ b/src/www/firewall_virtual_ip.php @@ -306,16 +306,16 @@ $main_buttons = array( @@ -329,10 +329,10 @@ $main_buttons = array( diff --git a/src/www/system_gateway_groups.php b/src/www/system_gateway_groups.php index 442375c67..d966615eb 100644 --- a/src/www/system_gateway_groups.php +++ b/src/www/system_gateway_groups.php @@ -195,12 +195,18 @@ $( document ).ready(function() { - "> + "> - " > + "> "> - " data-toggle="tooltip" data-placement="left" title=""> + " data-toggle="tooltip" data-placement="left" title=""> @@ -353,19 +353,19 @@ $( document ).ready(function() { diff --git a/src/www/system_routes.php b/src/www/system_routes.php index 3cc9a8896..47993b0ba 100644 --- a/src/www/system_routes.php +++ b/src/www/system_routes.php @@ -254,8 +254,8 @@ endif; ?> @@ -272,18 +272,20 @@ endif; ?> @@ -300,12 +302,11 @@ endif; ?> title="" alt="move" /> - - @@ -314,9 +315,12 @@ endif; ?> - + + " data-toggle="tooltip" data-placement="left"> + + diff --git a/src/www/vpn_ipsec.php b/src/www/vpn_ipsec.php index 8096fa5f4..0cb98b6d7 100644 --- a/src/www/vpn_ipsec.php +++ b/src/www/vpn_ipsec.php @@ -298,8 +298,8 @@ foreach ($pconfig['phase1'] as $ph1ent) : @@ -362,16 +362,16 @@ if (!empty($ph1ent['encryption-algorithm']['keylen'])) {   @@ -488,24 +488,26 @@ if (!empty($ph2ent['hash-algorithm-option']) && is_array($ph2ent['hash-algorithm @@ -521,25 +523,25 @@ endforeach; ?> - " class="btn btn-default btn-xs"> - " alt="add" class="glyphicon glyphicon-plus"> - 0) : ?> - + " class="btn btn-default btn-xs" + title="" data-toggle="tooltip" data-placement="left"> + + @@ -556,21 +558,24 @@ endforeach; // $a_phase1 as $ph1ent
   
- " class="btn btn-default btn-xs"> + " class="btn btn-default btn-xs">
- " class="btn btn-default btn-xs"> + " class="btn btn-default btn-xs">
- " class="btn btn-default btn-xs"> + " class="btn btn-default btn-xs">
- " class="btn btn-default btn-xs"> + " class="btn btn-default btn-xs">
- "> - - + "> "> @@ -525,13 +523,13 @@ $( document ).ready(function() { " class="act_move btn btn-default btn-xs"> - " class="btn btn-default btn-xs"> + " class="btn btn-default btn-xs"> - " data-toggle="tooltip" class="act_delete btn btn-default btn-xs"> + " data-toggle="tooltip" class="act_delete btn btn-default btn-xs"> - "> + "> - " class="btn btn-default btn-xs"> + " class="btn btn-default btn-xs"> - " data-toggle="tooltip" class="act_delete btn btn-default btn-xs"> + " data-toggle="tooltip" class="act_delete btn btn-default btn-xs"> - "> + "> - " class="act_move btn btn-default btn-xs"> + " class="act_move btn btn-default btn-xs"> - " class="btn btn-default btn-xs"> + " class="btn btn-default btn-xs"> - " data-toggle="tooltip" class="act_delete btn btn-default btn-xs"> + " data-toggle="tooltip" class="act_delete btn btn-default btn-xs"> - "> + ">
- " class="act_move btn btn-default btn-xs"> + " class="act_move btn btn-default btn-xs"> - "> + "> - + + + - + + +
"> + data-toggle="tooltip" data-placement="left" title=""> - "> + data-toggle="tooltip" data-placement="left" title=""> - " - title="" alt="icon"> + " data-toggle="tooltip" data-placement="left" + title="" alt="icon"> - " class="act_move btn btn-default btn-xs"> + " class="act_move btn btn-default btn-xs"> - - " alt="edit"> + " data-toggle="tooltip" data-placement="left"> + - - " alt="duplicate"> + " data-toggle="tooltip" data-placement="left"> +
- - - " class="btn btn-default btn-xs" alt="edit"> - + " data-toggle="tooltip" data-placement="left"> +
- " class="btn btn-default btn-xs" alt="add"> + " data-toggle="tooltip" data-placement="left"> $ph2ent) :
- - " alt="edit" class="btn btn-default btn-xs"> + " data-toggle="tooltip" data-placement="left" + alt="edit" class="btn btn-default btn-xs"> - - " alt="add" class="btn btn-default btn-xs"> + " data-toggle="tooltip" data-placement="left" + alt="add" class="btn btn-default btn-xs">
- " alt="add" class="btn btn-default btn-xs"> - - + " data-toggle="tooltip" data-placement="left" + alt="add" class="btn btn-default btn-xs"> + +