lucaspalomodevelop/core
1
0
Fork 0
mirror of https://github.com/lucaspalomodevelop/core.git synced 2026-03-17 18:14:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Auth/vouchers - fix integer validation, closes https://github.com/opnsense/core/issues/7105

Browse Source
This commit is contained in:
Ad Schellevis 2023-12-28 13:31:29 +01:00
parent 14f843bb2f
commit d7a858de34
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/opnsense/mvc/app/library/OPNsense/Auth/Voucher.php
View File

@ -204,11 +204,11 @@ class Voucher extends Base implements IAuthConnector
$expirytime = $expirytime == 0 ? 0 : $expirytime + time();
while ($vouchersGenerated < $count) {
$generatedUsername = '';
for ($j = 0; $j < $this->usernameLength; $j++) {
for ($j = 0; $j < max($this->usernameLength, 1); $j++) {
$generatedUsername .= $characterMap[random_int(0, strlen($characterMap) - 1)];
}
$generatedPassword = '';
for ($j = 0; $j < $this->passwordLength; $j++) {
for ($j = 0; $j < max($this->passwordLength, 1); $j++) {
$generatedPassword .= $characterMap[random_int(0, strlen($characterMap) - 1)];
}
@ -423,7 +423,7 @@ class Voucher extends Base implements IAuthConnector
$fields["usernameLength"]["default"] = null;
$fields["usernameLength"]["help"] = gettext("Specify alternative username length for generating vouchers");
$fields["usernameLength"]["validate"] = function ($value) {
if (!empty($value) && filter_var($value, FILTER_SANITIZE_NUMBER_INT) != $value) {
if ($value != '' && (filter_var($value, FILTER_SANITIZE_NUMBER_INT) != $value || $value < 1)) {
return array(gettext("Username length must be a number or empty for default."));
} else {
return array();
@ -435,7 +435,7 @@ class Voucher extends Base implements IAuthConnector
$fields["passwordLength"]["default"] = null;
$fields["passwordLength"]["help"] = gettext("Specify alternative password length for generating vouchers");
$fields["passwordLength"]["validate"] = function ($value) {
if (!empty($value) && filter_var($value, FILTER_SANITIZE_NUMBER_INT) != $value) {
if ($value != '' && (filter_var($value, FILTER_SANITIZE_NUMBER_INT) != $value || $value < 1)) {
return array(gettext("Password length must be a number or empty for default."));
} else {
return array();