lucaspalomodevelop/core
1
0
Fork 0
mirror of https://github.com/lucaspalomodevelop/core.git synced 2026-03-20 11:26:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

settings: tweaking the tweaks

Browse Source 
* Do not patronise the user about advanced settings.  The user should
  know what she's doing.  ;)

* Hide the tabs page by moving it from .php to .inc -- web server acces
  to this file extensions is forbidden.  Tabs do not have authentication
  and that's bad if left untreated...
This commit is contained in:
Franco Fichtner 2015-04-13 08:11:08 +02:00
parent 1e194c54d3
commit d71e272515
9 changed files with 22 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/www/system_advanced_admin.php
View File

@ -293,8 +293,7 @@ include("head.inc");
if ($savemsg) print_info_box($savemsg);
?>
<section class="col-xs-12">
<? include('system_advanced_tabs.php'); ?>
<? include('system_advanced_tabs.inc'); ?>
<div class="content-box tab-content">
<form action="system_advanced_admin.php" method="post" name="iform" id="iform">

4
src/www/system_advanced_firewall.php
View File

@ -250,9 +250,7 @@ include("head.inc");
if ($savemsg) print_info_box($savemsg);
?>
<section class="col-xs-12">
<? include('system_advanced_tabs.php'); ?>
<? include('system_advanced_tabs.inc'); ?>
<div class="content-box tab-content">
<form action="system_advanced_firewall.php" method="post" name="iform" id="iform">

2
src/www/system_advanced_misc.php
View File

@ -263,7 +263,7 @@ include("head.inc");
if ($savemsg) print_info_box($savemsg);
?>
<section class="col-xs-12">
<? include('system_advanced_tabs.php'); ?>
<? include('system_advanced_tabs.inc'); ?>
<div class="content-box tab-content">
<form action="system_advanced_misc.php" method="post" name="iform" id="iform">
<table width="100%" border="0" cellpadding="6" cellspacing="0" summary="main area" class="table table-striped">

2
src/www/system_advanced_network.php
View File

@ -172,7 +172,7 @@ include("head.inc");
if ($savemsg) print_info_box($savemsg);
?>
<section class="col-xs-12">
<? include('system_advanced_tabs.php'); ?>
<? include('system_advanced_tabs.inc'); ?>
<div class="content-box tab-content">
<form action="system_advanced_network.php" method="post" name="iform" id="iform">

3
src/www/system_advanced_notifications.php
View File

@ -169,8 +169,7 @@ include("head.inc");
</form>
<section class="col-xs-12">
<? include('system_advanced_tabs.php'); ?>
<? include('system_advanced_tabs.inc'); ?>
<div class="content-box tab-content">
<form action="system_advanced_notifications.php" method="post" name="iform">

3
src/www/system_advanced_sysctl.php
View File

@ -1,4 +1,5 @@
<?php
/*
Copyright (C) 2014-2015 Deciso B.V.
Copyright (C) 2005-2007 Scott Ullrich
@ -133,7 +134,7 @@ include("head.inc");
</form>
<section class="col-xs-12">
<? include('system_advanced_tabs.php'); ?>
<? include('system_advanced_tabs.inc'); ?>
<div class="table-responsive content-box tab-content" style="overflow: auto;">
<?php if ($act != "edit" ): ?>
<table width="100%" border="0" cellpadding="6" cellspacing="0" summary="main area" class="table table-striped">

14
src/www/system_advanced_tabs.inc Normal file
View File

@ -0,0 +1,14 @@
<?php
$active_tab = isset($active_tab) ? $active_tab : $_SERVER['PHP_SELF'];
$tab_array = array();
$tab_array[] = array(gettext("General"), $active_tab == "/system_general.php", "system_general.php");
$tab_array[] = array(gettext("Admin Access"), $active_tab == "/system_advanced_admin.php", "system_advanced_admin.php");
$tab_array[] = array(gettext("Firewall / NAT"), $active_tab == "/system_advanced_firewall.php", "system_advanced_firewall.php");
$tab_array[] = array(gettext("Networking"), $active_tab == "/system_advanced_network.php", "system_advanced_network.php");
$tab_array[] = array(gettext("Miscellaneous"), $active_tab == "/system_advanced_misc.php", "system_advanced_misc.php");
$tab_array[] = array(gettext("System Tunables"), $active_tab == "/system_advanced_sysctl.php", "system_advanced_sysctl.php");
$tab_array[] = array(gettext("Notifications"), $active_tab == "/system_advanced_notifications.php", "system_advanced_notifications.php");
display_top_tabs($tab_array);

17
src/www/system_advanced_tabs.php
View File

@ -1,17 +0,0 @@
<div class="alert alert-info alert-dismissible" role="alert">
<button type="button" class="close" data-dismiss="alert"><span aria-hidden="true">&times;</span><span class="sr-only">Close</span></button>
<strong><?=gettext("NOTE:"); ?></strong>&nbsp;<?=gettext("The options on this page are intended for use by advanced users only."); ?>
</div>
<?php
$active_tab = isset($active_tab) ? $active_tab : $_SERVER['PHP_SELF'];
$tab_array = array();
$tab_array[] = array(gettext("General"), $active_tab == "/system_general.php", "system_general.php");
$tab_array[] = array(gettext("Admin Access"), $active_tab == "/system_advanced_admin.php", "system_advanced_admin.php");
$tab_array[] = array(gettext("Firewall / NAT"), $active_tab == "/system_advanced_firewall.php", "system_advanced_firewall.php");
$tab_array[] = array(gettext("Networking"), $active_tab == "/system_advanced_network.php", "system_advanced_network.php");
$tab_array[] = array(gettext("Miscellaneous"), $active_tab == "/system_advanced_misc.php", "system_advanced_misc.php");
$tab_array[] = array(gettext("System Tunables"), $active_tab == "/system_advanced_sysctl.php", "system_advanced_sysctl.php");
$tab_array[] = array(gettext("Notifications"), $active_tab == "/system_advanced_notifications.php", "system_advanced_notifications.php");
display_top_tabs($tab_array);
?>

3
src/www/system_general.php
View File

@ -287,8 +287,7 @@ include("head.inc");
if ($savemsg) print_info_box($savemsg);
?>
<section class="col-xs-12">
<? include('system_advanced_tabs.php'); ?>
<? include('system_advanced_tabs.inc'); ?>
<div class="content-box tab-content">
<form action="system_general.php" method="post">