From d4db4023e6463b7b1eebbb173e7a6a3e83dceb18 Mon Sep 17 00:00:00 2001
From: Franco Fichtner <franco@opnsense.org>
Date: Tue, 22 Nov 2022 16:42:43 +0100
Subject: [PATCH] interfaces: use get_interface_list() to identify hardware

Media settings probe is suboptimal for hardware detection and
interfaces_hardware() already uses the function to decide where
to enforce hardware settings.

PR: https://forum.opnsense.org/index.php?topic=30923.0
---
 src/www/interfaces.php | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/src/www/interfaces.php b/src/www/interfaces.php
index 5625fd7cb..73ee60d6e 100644
--- a/src/www/interfaces.php
+++ b/src/www/interfaces.php
@@ -328,6 +328,7 @@ function get_wireless_channel_info($interface)
 }
 
 $ifdescrs = legacy_config_get_interfaces(['virtual' => false]);
+$hwifs = array_keys(get_interface_list());
 
 $a_interfaces = &config_read_array('interfaces');
 $a_ppps = &config_read_array('ppps', 'ppp');
@@ -2014,8 +2015,7 @@ include("head.inc");
                     </table>
                   </div>
                 </div>
-<?php
-                if (count($mediaopts_list) > 1):?>
+<?php if (in_array($pconfig['if'], $hwifs)): ?>
                 <!-- Hardware settings -->
                 <div class="tab-content content-box col-xs-12 __mb">
                   <div class="table-responsive">
@@ -2088,8 +2088,7 @@ include("head.inc");
                     </table>
                   </div>
                 </div>
-<?php
-                endif;?>
+<?php endif ?>
                 <!-- static IPv4 -->
                 <div class="tab-content content-box col-xs-12 __mb" id="staticv4" style="display:none">
                   <div class="table-responsive">