From d4cf6d17fb8e8239031fcf727400e9806684e249 Mon Sep 17 00:00:00 2001
From: djGrrr <github@linuxhosted.ca>
Date: Sun, 5 Feb 2017 15:42:42 -0330
Subject: [PATCH] fix double encoding of NO NAT for NAT addresses

---
 src/www/firewall_nat_out.php | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/www/firewall_nat_out.php b/src/www/firewall_nat_out.php
index f10c565a3..4f04ac2a7 100644
--- a/src/www/firewall_nat_out.php
+++ b/src/www/firewall_nat_out.php
@@ -447,18 +447,18 @@ include("head.inc");
                       elseif ($natent['target'] == "other-subnet")
                         $nat_address = $natent['targetip'] . '/' . $natent['targetip_subnet'];
                       else
-                        $nat_address = $natent['target'];
+                        $nat_address = htmlspecialchars($natent['target']);
 ?>
 <?php                 if (isset($natent['target']) && is_alias($natent['target'])): ?>
                         <span title="<?=htmlspecialchars(get_alias_description($natent['target']));?>" data-toggle="tooltip">
-                          <?=htmlspecialchars($nat_address);?>&nbsp;
+                          <?=$nat_address;?>&nbsp;
                         </span>
                         <a href="/firewall_aliases_edit.php?name=<?=htmlspecialchars($natent['target']);?>"
                             title="<?=gettext("edit alias");?>" data-toggle="tooltip">
                           <i class="fa fa-list"></i>
                         </a>
 <?php                 else: ?>
-                        <?=htmlspecialchars($nat_address);?>
+                        <?=$nat_address;?>
 <?php                 endif; ?>
                     </td>
                     <td class="hidden-xs hidden-sm">
@@ -611,7 +611,7 @@ include("head.inc");
                     } elseif ($natent['target'] == "other-subnet") {
                         $nat_address = $natent['targetip'] . '/' . $natent['targetip_subnet'];
                     } else  {
-                        $nat_address = $natent['target'];
+                        $nat_address = htmlspecialchars($natent['target']);
                     }
 ?>
                     <?=$nat_address;?>