From d292ee4ed7fab1ececdd115a828bdf9bf7602d17 Mon Sep 17 00:00:00 2001
From: Ad Schellevis <ad@opnsense.org>
Date: Thu, 31 Dec 2015 16:42:23 +0100
Subject: [PATCH] (legacy) refactor interfaces_lagg.php

---
 src/www/interfaces_lagg.php | 267 +++++++++++++++++++-----------------
 1 file changed, 143 insertions(+), 124 deletions(-)

diff --git a/src/www/interfaces_lagg.php b/src/www/interfaces_lagg.php
index 4b6d5e6b4..78fdbec73 100644
--- a/src/www/interfaces_lagg.php
+++ b/src/www/interfaces_lagg.php
@@ -1,151 +1,170 @@
 <?php
 
 /*
-	Copyright (C) 2014-2015 Deciso B.V.
-	Copyright (C) 2008 Ermal Luçi
-	All rights reserved.
+  Copyright (C) 2014-2015 Deciso B.V.
+  Copyright (C) 2008 Ermal Luçi
+  All rights reserved.
 
-	Redistribution and use in source and binary forms, with or without
-	modification, are permitted provided that the following conditions are met:
+  Redistribution and use in source and binary forms, with or without
+  modification, are permitted provided that the following conditions are met:
 
-	1. Redistributions of source code must retain the above copyright notice,
-	   this list of conditions and the following disclaimer.
+  1. Redistributions of source code must retain the above copyright notice,
+     this list of conditions and the following disclaimer.
 
-	2. Redistributions in binary form must reproduce the above copyright
-	   notice, this list of conditions and the following disclaimer in the
-	   documentation and/or other materials provided with the distribution.
+  2. Redistributions in binary form must reproduce the above copyright
+     notice, this list of conditions and the following disclaimer in the
+     documentation and/or other materials provided with the distribution.
 
-	THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES,
-	INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY
-	AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
-	AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY,
-	OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
-	SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
-	INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
-	CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
-	ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
-	POSSIBILITY OF SUCH DAMAGE.
+  THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES,
+  INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY
+  AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
+  AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY,
+  OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+  SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+  INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+  CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+  ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+  POSSIBILITY OF SUCH DAMAGE.
 */
 
 require_once("guiconfig.inc");
 
-if (!isset($config['laggs']['lagg'])) {
-	$config['laggs']['lagg'] = array();
-}
 
-$a_laggs = &$config['laggs']['lagg'] ;
-
-function lagg_inuse($num) {
-	global $config, $a_laggs;
-
-	$iflist = get_configured_interface_list(false, true);
-	foreach ($iflist as $if) {
-		if ($config['interfaces'][$if]['if'] == $a_laggs[$num]['laggif'])
-			return true;
-	}
-
-	if (isset($config['vlans']['vlan'])) {
-                foreach ($config['vlans']['vlan'] as $vlan) {
-                        if($vlan['if'] == $a_laggs[$num]['laggif'])
-				return true;
-                }
+function lagg_inuse($lagg_intf) {
+    global $config;
+    $iflist = get_configured_interface_list(false, true);
+    foreach ($iflist as $if) {
+        if ($config['interfaces'][$if]['if'] == $lagg_intf) {
+            return true;
         }
-	return false;
+    }
+    if (isset($config['vlans']['vlan'])) {
+        foreach ($config['vlans']['vlan'] as $vlan) {
+            if($vlan['if'] == $lagg_intf) {
+                return true;
+            }
+        }
+    }
+    return false;
 }
 
-if ($_GET['act'] == "del") {
-        if (!isset($_GET['id']))
-                $input_errors[] = gettext("Wrong parameters supplied");
-        else if (empty($a_laggs[$_GET['id']]))
-                $input_errors[] = gettext("Wrong index supplied");
-	/* check if still in use */
-	else if (lagg_inuse($_GET['id'])) {
-		$input_errors[] = gettext("This LAGG interface cannot be deleted because it is still being used.");
-	} else {
-		mwexec_bg("/sbin/ifconfig " . $a_laggs[$_GET['id']]['laggif'] . " destroy");
-		unset($a_laggs[$_GET['id']]);
 
-		write_config();
-
-		header("Location: interfaces_lagg.php");
-		exit;
-	}
+if (!isset($config['laggs']['lagg'])) {
+    $a_laggs = array();
+} else {
+    $a_laggs = &$config['laggs']['lagg'] ;
 }
 
+
+if ($_SERVER['REQUEST_METHOD'] === 'POST') {
+    if (!empty($a_laggs[$_POST['id']])) {
+        $id = $_POST['id'];
+    }
+
+    if (!empty($_POST['action']) && $_POST['action'] == "del" && isset($id)) {
+        if (lagg_inuse($a_laggs[$id]['laggif'])) {
+            $input_errors[] = gettext("This LAGG interface cannot be deleted because it is still being used.");
+        } else {
+            mwexec_bg("/sbin/ifconfig " . escapeshellarg($a_laggs[$id]['laggif']) . " destroy");
+            unset($a_laggs[$id]);
+            write_config();
+            header("Location: interfaces_lagg.php");
+            exit;
+        }
+    }
+}
+
+
 include("head.inc");
-
+legacy_html_escape_form_data($a_laggs);
 $main_buttons = array(
-	array('href'=>'interfaces_lagg_edit.php', 'label'=>gettext('Add')),
+  array('href'=>'interfaces_lagg_edit.php', 'label'=>gettext('Add')),
 );
 
 ?>
 
 <body>
+  <script type="text/javascript">
+  $( document ).ready(function() {
+    // link delete buttons
+    $(".act_delete").click(function(event){
+      event.preventDefault();
+      var id = $(this).data("id");
+      // delete single
+      BootstrapDialog.show({
+        type:BootstrapDialog.TYPE_INFO,
+        title: "<?= gettext("LAGG");?>",
+        message: "<?=gettext("Do you really want to delete this LAGG interface?");?>",
+        buttons: [{
+                  label: "<?= gettext("No");?>",
+                  action: function(dialogRef) {
+                      dialogRef.close();
+                  }}, {
+                  label: "<?= gettext("Yes");?>",
+                  action: function(dialogRef) {
+                    $("#id").val(id);
+                    $("#action").val("del");
+                    $("#iform").submit()
+                }
+              }]
+      });
+    });
+
+  });
+  </script>
 <?php include("fbegin.inc"); ?>
-
-	<section class="page-content-main">
-		<div class="container-fluid">
-			<div class="row">
-
-				<?php if (isset($input_errors) && count($input_errors) > 0) print_input_errors($input_errors); ?>
-
-			    <section class="col-xs-12">
-
-						<div class="tab-content content-box col-xs-12">
-
-
-		                        <form action="interfaces_assign.php" method="post" name="iform" id="iform">
-
-		                        <div class="table-responsive">
-			                        <table class="table table-striped table-sort">
-
-										 <thead>
-                                            <tr>
-								<th width="20%" class="listtopic"><?=gettext("Interface");?></th>
-								<th width="20%" class="listtopic"><?=gettext("Members");?></th>
-								<th width="50%" class="listtopic"><?=gettext("Description");?></th>
-								<th width="10%" class="listtopic">&nbsp;</th>
-                                            </tr>
-                                        </thead>
-
-									<tbody>
-
-									  <?php $i = 0; foreach ($a_laggs as $lagg): ?>
-						                <tr  ondblclick="document.location='interfaces_lagg_edit.php?id=<?=$i;?>'">
-						                  <td class="listlr">
-											<?=htmlspecialchars(strtoupper($lagg['laggif']));?>
-						                  </td>
-						                  <td class="listr">
-											<?=htmlspecialchars($lagg['members']);?>
-						                  </td>
-						                  <td class="listbg">
-						                    <?=htmlspecialchars($lagg['descr']);?>&nbsp;
-						                  </td>
-						                  <td valign="middle" class="list nowrap">
-
-							                   <a href="interfaces_lagg_edit.php?id=<?=$i;?>" class="btn btn-default" data-toggle="tooltip" data-placement="left" title="<?=gettext("edit group");?>"><span class="glyphicon glyphicon-edit"></span></a>
-
-											   <a href="interfaces_lagg.php?act=del&amp;id=<?=$i;?>" class="btn btn-default" data-toggle="tooltip" data-placement="left" title="<?=gettext("delete group");?>" onclick="return confirm('<?=gettext("Do you really want to delete this LAGG interface?");?>')"><span class="glyphicon glyphicon-remove"></span></a>
-										  </td>
-										</tr>
-									  <?php $i++; endforeach; ?>
-
-									</tbody>
-						              </table>
-							      </div>
-
-							      <div class="container-fluid">
-							      <p class="vexpl"><span class="text-danger"><strong>
-										  <?=gettext("Note:"); ?><br />
-										  </strong></span>
-										  <?=gettext("LAGG allows for link aggregation, bonding and fault tolerance. Only unassigned interfaces can be added to LAGG."); ?></p>
-							      </div>
-
-		                        </form>
-						</div>
-			    </section>
-			</div>
-		</div>
-	</section>
-
+  <section class="page-content-main">
+    <div class="container-fluid">
+      <div class="row">
+        <?php if (isset($input_errors) && count($input_errors) > 0) print_input_errors($input_errors); ?>
+          <section class="col-xs-12">
+            <div class="tab-content content-box col-xs-12">
+              <form method="post" name="iform" id="iform">
+                <input type="hidden" id="action" name="action" value="">
+                <input type="hidden" id="id" name="id" value="">
+                <div class="table-responsive">
+                  <table class="table table-striped">
+                    <thead>
+                      <tr>
+                        <th><?=gettext("Interface");?></th>
+                        <th><?=gettext("Members");?></th>
+                        <th><?=gettext("Description");?></th>
+                        <th>&nbsp;</th>
+                      </tr>
+                    </thead>
+                    <tbody>
+<?php
+                    $i = 0;
+                    foreach ($a_laggs as $lagg): ?>
+                      <tr>
+                        <td><?=strtoupper($lagg['laggif']);?></td>
+                        <td><?=$lagg['members'];?></td>
+                        <td><?=$lagg['descr'];?></td>
+                        <td>
+                          <a href="interfaces_lagg_edit.php?id=<?=$i;?>" class="btn btn-xs btn-default" data-toggle="tooltip" data-placement="left" title="<?=gettext("edit interface");?>">
+                            <span class="glyphicon glyphicon-edit"></span>
+                          </a>
+                         <button title="<?=gettext("delete interface");?>" data-toggle="tooltip" data-placement="left" data-id="<?=$i;?>" class="btn btn-default btn-xs act_delete" type="submit">
+                           <span class=" glyphicon glyphicon-remove"></span>
+                         </button>
+                        </td>
+                      </tr>
+<?php
+                    $i++;
+                    endforeach; ?>
+                    </tbody>
+                  </table>
+                </div>
+              <div class="container-fluid">
+                <p>
+                  <span class="text-danger"><strong><?=gettext("Note:"); ?><br /></strong></span>
+                  <?=gettext("LAGG allows for link aggregation, bonding and fault tolerance. Only unassigned interfaces can be added to LAGG."); ?>
+                </p>
+              </div>
+            </form>
+          </div>
+        </section>
+      </div>
+    </div>
+  </section>
 <?php include("foot.inc"); ?>