From d240c8b0fa5f254475a0de0e2be5de2a6981139a Mon Sep 17 00:00:00 2001 From: Franco Fichtner Date: Tue, 8 Apr 2025 11:20:47 +0200 Subject: [PATCH] firmware: fix page after f569ead1a5371 changed the defaults Make it backwards-compatible but always store the new value now. # pluginctl -g firmware.reboot will still return an empty string instead of "0". --- src/opnsense/mvc/app/views/OPNsense/Core/firmware.volt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/opnsense/mvc/app/views/OPNsense/Core/firmware.volt b/src/opnsense/mvc/app/views/OPNsense/Core/firmware.volt index 8477362df..342514301 100644 --- a/src/opnsense/mvc/app/views/OPNsense/Core/firmware.volt +++ b/src/opnsense/mvc/app/views/OPNsense/Core/firmware.volt @@ -667,7 +667,7 @@ $("#firmware_mirror").find('option').remove(); $("#firmware_type").find('option').remove(); $("#firmware_flavour").find('option').remove(); - $("#firmware_reboot").prop('checked', firmwareconfig['reboot'] !== ''); + $("#firmware_reboot").prop('checked', firmwareconfig['reboot'] == '1'); $.each(firmwareoptions.mirrors, function(key, value) { var selected = false; @@ -764,7 +764,7 @@ confopt.mirror = $("#firmware_mirror_value").val(); confopt.flavour = $("#firmware_flavour_value").val(); confopt.type = $("#firmware_type").val(); - confopt.reboot = $("#firmware_reboot").is(":checked"); + confopt.reboot = $("#firmware_reboot").is(":checked") ? '1' : '0'; confopt.subscription = $("#firmware_subscription").val(); ajaxCall('/api/core/firmware/set', { 'firmware': confopt }, function (data, status) { $("#settingstab_progress").removeClass("fa fa-spinner fa-pulse");