diff --git a/src/etc/inc/filter_log.inc b/src/etc/inc/filter_log.inc index 2e2baf66a..118972448 100644 --- a/src/etc/inc/filter_log.inc +++ b/src/etc/inc/filter_log.inc @@ -41,7 +41,7 @@ function conv_log_interface_names() $interface_names['enc0'] = gettext("IPsec"); if (!empty($config['interfaces'])) { - foreach ($config['interfaces'] as $intfkey => $interface) { + foreach (legacy_config_get_interfaces(array("virtual" => false)) as $intfkey => $interface) { $interface_names[$interface['if']] = !empty($interface['descr']) ? $interface['descr'] : $intfkey; } } diff --git a/src/etc/inc/services.inc b/src/etc/inc/services.inc index a70f0ee34..c07270e1f 100644 --- a/src/etc/inc/services.inc +++ b/src/etc/inc/services.inc @@ -1066,7 +1066,7 @@ function is_dhcpv6_server_enabled() global $config; if (is_array($config['interfaces'])) { - foreach ($config['interfaces'] as $ifcfg) { + foreach (legacy_config_get_interfaces(array("virtual" => false)) as $ifcfg) { if (isset($ifcfg['enable']) && !empty($ifcfg['track6-interface'])) { return true; } diff --git a/src/etc/inc/util.inc b/src/etc/inc/util.inc index 42fa16deb..9b6133609 100644 --- a/src/etc/inc/util.inc +++ b/src/etc/inc/util.inc @@ -732,7 +732,7 @@ function get_configured_interface_list($only_opt = false, $withdisabled = false) /* if list */ if (isset($config['interfaces'])) { - foreach($config['interfaces'] as $if => $ifdetail) { + foreach (legacy_config_get_interfaces(array("virtual" => false)) as $if => $ifdetail) { if ($only_opt && ($if == "wan" || $if == "lan")) { continue; } @@ -753,7 +753,7 @@ function get_configured_interface_list_by_realif ($only_opt = false, $withdisabl $iflist = array(); /* if list */ if (isset($config['interfaces'])) { - foreach($config['interfaces'] as $if => $ifdetail) { + foreach (legacy_config_get_interfaces(array("virtual" => false)) as $if => $ifdetail) { if ($only_opt && ($if == "wan" || $if == "lan")) { continue; } @@ -776,17 +776,13 @@ function get_configured_interface_with_descr($only_opt = false, $withdisabled = $iflist = array(); /* if list */ if (isset($config['interfaces'])) { - foreach($config['interfaces'] as $if => $ifdetail) { + foreach (legacy_config_get_interfaces(array("virtual" => false)) as $if => $ifdetail) { if ($only_opt && ($if == "wan" || $if == "lan")) { continue; } if (isset($ifdetail['enable']) || $withdisabled == true) { - if (empty($ifdetail['descr'])) { - $iflist[$if] = strtoupper($if); - } else { - $iflist[$if] = strtoupper($ifdetail['descr']); - } + $iflist[$if] = strtoupper($ifdetail['descr']); } } } @@ -925,7 +921,7 @@ function get_interface_list($only_active = false) ); if (isset($config['interfaces'])) { - foreach($config['interfaces'] as $name => $int) { + foreach (legacy_config_get_interfaces(array("virtual" => false)) as $name => $int) { if ($int['if'] == $ifname) { $toput['friendly'] = $name; break; diff --git a/src/etc/rc.bootup b/src/etc/rc.bootup index cf9334c75..086c0830d 100755 --- a/src/etc/rc.bootup +++ b/src/etc/rc.bootup @@ -55,7 +55,7 @@ function is_interface_mismatch() $i = 0; if (isset($config['interfaces'])) { - foreach ($config['interfaces'] as $ifname => $ifcfg) { + foreach (legacy_config_get_interfaces(array("virtual" => false)) as $ifname => $ifcfg) { if (preg_match("/^enc|^cua|^tun|^tap|^l2tp|^pptp|^ppp|^ovpn|^gif|^gre|^lagg|^bridge|vlan|_wlan/i", $ifcfg['if'])) { /* Do not check these interfaces */ $i++; diff --git a/src/etc/rc.newwanip b/src/etc/rc.newwanip index b4e072503..3a2da5aaa 100755 --- a/src/etc/rc.newwanip +++ b/src/etc/rc.newwanip @@ -163,7 +163,7 @@ if (isset($config['interfaces'][$interface]['ipaddrv6'])) { if(isset($config['gifs']['gif']) && is_array($config['gifs']['gif'])){ foreach($config['gifs']['gif'] as $gif) { if($gif['if'] == $interface) { - foreach($config['interfaces'] as $ifname => $ifparent) { + foreach (legacy_config_get_interfaces(array("virtual" => false)) as $ifname => $ifparent) { if(($ifparent['if'] == $gif['gifif']) && (isset($ifparent['enable']))) { $gif['gifif'] = interface_gif_configure($gif); $confif = convert_real_interface_to_friendly_interface_name($gif['gifif']); diff --git a/src/www/firewall_nat_out_edit.php b/src/www/firewall_nat_out_edit.php index c39152f71..28fb4911b 100644 --- a/src/www/firewall_nat_out_edit.php +++ b/src/www/firewall_nat_out_edit.php @@ -38,8 +38,8 @@ require_once("filter.inc"); function formInterfaces() { global $config; $interfaces = array(); - foreach ( get_configured_interface_with_descr(false, true) as $if => $ifdesc) { - $interfaces[$if] = $ifdesc; + foreach (legacy_config_get_interfaces() as $if => $ifdata) { + $interfaces[$if] = $ifdata['descr']; } if (isset($config['l2tp']['mode']) && $config['l2tp']['mode'] == "server") { diff --git a/src/www/interfaces_bridge.php b/src/www/interfaces_bridge.php index fd87a7127..6f027479d 100644 --- a/src/www/interfaces_bridge.php +++ b/src/www/interfaces_bridge.php @@ -39,8 +39,7 @@ if (!isset($config['bridges']['bridged']) || !is_array($config['bridges']['bridg function bridge_inuse($bridge_if) { - global $config; - foreach ($config['interfaces'] as $if => $intf) { + foreach (legacy_config_get_interfaces() as $if => $intf) { if ($intf['if'] == $bridge_if) { return true; } diff --git a/src/www/interfaces_gif.php b/src/www/interfaces_gif.php index b1410be6e..365533260 100644 --- a/src/www/interfaces_gif.php +++ b/src/www/interfaces_gif.php @@ -31,8 +31,7 @@ require_once("guiconfig.inc"); require_once("interfaces.inc"); function gif_inuse($gif_intf) { - global $config; - foreach ($config['interfaces'] as $if => $intf) { + foreach (legacy_config_get_interfaces() as $if => $intf) { if ($intf['if'] == $gif_intf) { return true; } diff --git a/src/www/interfaces_gre.php b/src/www/interfaces_gre.php index cecbf2749..1dbbce706 100644 --- a/src/www/interfaces_gre.php +++ b/src/www/interfaces_gre.php @@ -31,8 +31,7 @@ require_once("guiconfig.inc"); require_once("interfaces.inc"); function gre_inuse($gre_intf) { - global $config; - foreach ($config['interfaces'] as $if => $intf) { + foreach (legacy_config_get_interfaces() as $if => $intf) { if ($intf['if'] == $gre_intf) { return true; } diff --git a/src/www/interfaces_ppps.php b/src/www/interfaces_ppps.php index 22b269ddf..5977b52dc 100644 --- a/src/www/interfaces_ppps.php +++ b/src/www/interfaces_ppps.php @@ -33,7 +33,7 @@ require_once("interfaces.inc"); function ppp_inuse($ppp_intf) { global $config; if (isset($config['ppps']['ppp']) && !is_array($config['ppps']['ppp'])) { - foreach ($config['interfaces'] as $intf) { + foreach (legacy_config_get_interfaces(array("virtual" => false)) as $intf) { if ($intf['if'] == $ppp_intf) { return true; } diff --git a/src/www/interfaces_qinq.php b/src/www/interfaces_qinq.php index 5878cdeff..714cc1967 100644 --- a/src/www/interfaces_qinq.php +++ b/src/www/interfaces_qinq.php @@ -32,7 +32,7 @@ require_once("interfaces.inc"); function qinq_inuse($qinq_intf) { global $config; - foreach ($config['interfaces'] as $if => $intf) { + foreach (legacy_config_get_interfaces(array("virtual" => false)) as $if => $intf) { if ($intf['if'] == $qinq_intf) { return true; } diff --git a/src/www/services_dhcp.php b/src/www/services_dhcp.php index 9d4532521..97eb34cb5 100644 --- a/src/www/services_dhcp.php +++ b/src/www/services_dhcp.php @@ -51,7 +51,7 @@ function dhcp_clean_leases() /* Build list of static MACs */ $staticmacs = array(); - foreach($config['interfaces'] as $ifname => $ifarr) { + foreach (legacy_config_get_interfaces(array("virtual" => false)) as $ifname => $ifarr) { if (isset($config['dhcpd'][$ifname]['staticmap'])) { foreach($config['dhcpd'][$ifname]['staticmap'] as $static) { $staticmacs[] = $static['mac']; @@ -145,7 +145,7 @@ if ($_SERVER['REQUEST_METHOD'] === 'GET') { /* If no interface is provided, choose first one from interfaces */ if (!isset($if)) { - foreach ($config['interfaces'] as $if_id => $intf) { + foreach (legacy_config_get_interfaces(array("virtual" => false)) as $if_id => $intf) { if (!empty($intf['enable']) && is_ipaddrv4($intf['ipaddr'])) { $if = $if_id; break; @@ -675,7 +675,7 @@ include("head.inc"); $intf) { + foreach (legacy_config_get_interfaces(array("virtual" => false)) as $if_id => $intf) { if (isset($intf['enable']) && is_ipaddrv4($intf['ipaddr'])) { $ifname = !empty($intf['descr']) ? htmlspecialchars($intf['descr']) : strtoupper($if_id); if ($if_id == $if) { diff --git a/src/www/services_dhcpv6.php b/src/www/services_dhcpv6.php index 928c2393a..cb51fd543 100644 --- a/src/www/services_dhcpv6.php +++ b/src/www/services_dhcpv6.php @@ -72,7 +72,7 @@ if ($_SERVER['REQUEST_METHOD'] === 'GET') { "The DHCPv6 Server can only be enabled on interfaces configured with static " . "IP addresses. Only interfaces configured with a static IP will be shown." ); - foreach ($config['interfaces'] as $if_id => $intf) { + foreach (legacy_config_get_interfaces(array("virtual" => false)) as $if_id => $intf) { if (!empty($intf['enable']) && isset($intf['ipaddrv6']) && is_ipaddrv6($intf['ipaddrv6']) && !is_linklocal($intf['ipaddrv6'])) { $if = $if_id; break; @@ -443,7 +443,7 @@ include("head.inc"); $intf) { + foreach (legacy_config_get_interfaces(array("virtual" => false)) as $if_id => $intf) { if (isset($intf['enable']) && isset($intf['ipaddrv6']) && is_ipaddrv6($intf['ipaddrv6'])) { $ifname = !empty($intf['descr']) ? htmlspecialchars($intf['descr']) : strtoupper($if_id); if ($if_id == $if) { diff --git a/src/www/services_router_advertisements.php b/src/www/services_router_advertisements.php index 1af5086aa..89ea41c40 100644 --- a/src/www/services_router_advertisements.php +++ b/src/www/services_router_advertisements.php @@ -38,7 +38,7 @@ if ($_SERVER['REQUEST_METHOD'] === 'GET') { } else { $savemsg = "

" . gettext("The DHCPv6 Server can only be enabled on interfaces configured with static IP addresses") . ".

" . "

" . gettext("Only interfaces configured with a static IP will be shown") . ".

"; - foreach ($config['interfaces'] as $if_id => $intf) { + foreach (legacy_config_get_interfaces(array("virtual" => false)) as $if_id => $intf) { if (!empty($intf['enable']) && is_ipaddrv6($intf['ipaddrv6']) && !is_linklocal($oc['ipaddrv6'])) { $if = $if_id; break; @@ -173,7 +173,7 @@ include("head.inc"); $intf) { + foreach (legacy_config_get_interfaces(array("virtual" => false)) as $if_id => $intf) { if (!empty($intf['enable']) && is_ipaddrv6($intf['ipaddrv6'])) { $ifname = !empty($intf['descr']) ? htmlspecialchars($intf['descr']) : strtoupper($if_id); if ($if_id == $if) { diff --git a/src/www/status_dhcp_leases.php b/src/www/status_dhcp_leases.php index 3ec9e84af..a65c9968c 100644 --- a/src/www/status_dhcp_leases.php +++ b/src/www/status_dhcp_leases.php @@ -227,7 +227,7 @@ if ($_SERVER['REQUEST_METHOD'] === 'GET') { asort($pools); } - foreach($config['interfaces'] as $ifname => $ifarr) { + foreach (legacy_config_get_interfaces(array("virtual" => false)) as $ifname => $ifarr) { if (isset($config['dhcpd'][$ifname]['staticmap'])) { foreach($config['dhcpd'][$ifname]['staticmap'] as $static) { $slease = array(); diff --git a/src/www/status_dhcpv6_leases.php b/src/www/status_dhcpv6_leases.php index 8552e9069..686aa383a 100644 --- a/src/www/status_dhcpv6_leases.php +++ b/src/www/status_dhcpv6_leases.php @@ -293,7 +293,7 @@ if ($_SERVER['REQUEST_METHOD'] === 'GET') { asort($pools); } - foreach($config['interfaces'] as $ifname => $ifarr) { + foreach (legacy_config_get_interfaces(array("virtual" => false)) as $ifname => $ifarr) { if (isset($config['dhcpdv6'][$ifname]['staticmap'])) { foreach($config['dhcpdv6'][$ifname]['staticmap'] as $static) { $slease = array(); diff --git a/src/www/system_routes_edit.php b/src/www/system_routes_edit.php index af75b97cf..13b887411 100644 --- a/src/www/system_routes_edit.php +++ b/src/www/system_routes_edit.php @@ -164,7 +164,7 @@ if ($_SERVER['REQUEST_METHOD'] === 'GET') { } if (is_array($config['interfaces'])) { - foreach ($config['interfaces'] as $if) { + foreach (legacy_config_get_interfaces(array("virtual" => false)) as $if) { if (is_ipaddrv4($pconfig['network']) && isset($if['ipaddr']) && isset($if['subnet']) && is_ipaddrv4($if['ipaddr']) && is_numeric($if['subnet']) diff --git a/src/www/widgets/api/plugins/traffic.inc b/src/www/widgets/api/plugins/traffic.inc index ca96f2ba3..e4632ebdc 100644 --- a/src/www/widgets/api/plugins/traffic.inc +++ b/src/www/widgets/api/plugins/traffic.inc @@ -33,7 +33,7 @@ function traffic_api() $temp = gettimeofday(); $result['time'] = (double)$temp["sec"] + (double)$temp["usec"] / 1000000.0; // collect user friendly interface names - foreach ($config['interfaces'] as $interfaceKey => $interfaceData) { + foreach (legacy_config_get_interfaces(array("virtual" => false)) as $interfaceKey => $interfaceData) { if (array_key_exists($interfaceData['if'], $result['interfaces'])) { $result['interfaces'][$interfaceData['if']]['name'] = !empty($interfaceData['descr']) ? $interfaceData['descr'] : $interfaceKey; }