From ced78b04381f1a3c7bf55c664129f16385acff33 Mon Sep 17 00:00:00 2001
From: Franco Fichtner <franco@opnsense.org>
Date: Sat, 16 Jul 2016 11:45:34 +0200
Subject: [PATCH] openvpn: repair display of selected CRL

---
 src/www/vpn_openvpn_server.php | 26 ++++++++++++--------------
 1 file changed, 12 insertions(+), 14 deletions(-)

diff --git a/src/www/vpn_openvpn_server.php b/src/www/vpn_openvpn_server.php
index c06ee2a41..5126aea3b 100644
--- a/src/www/vpn_openvpn_server.php
+++ b/src/www/vpn_openvpn_server.php
@@ -817,21 +817,19 @@ endif; ?>
                           <option value="">None</option>
 <?php
                           foreach ($config['crl'] as $crl) :
-                              if (isset($acrl['refid'])) {
-                                  $selected = "";
-                                  $caname = "";
-                                  $ca = lookup_ca($crl['caref']);
-                                  if ($ca) {
-                                      $caname = " (CA: {$ca['descr']})";
-                                      if ($pconfig['crlref'] == $crl['refid']) {
-                                          $selected = "selected=\"selected\"";
-                                      }
-                                  }
-                              }?>
-                            <option value="<?=htmlspecialchars($crl['refid']);?>" <?=$selected;?>>
-                              <?=htmlspecialchars($crl['descr'] . $caname);?>
-                            </option>
+                              if (!isset($crl['refid'])) {
+                                  continue;
+                              }
+                              $ca = lookup_ca($crl['caref']);
+                              if ($ca) {
+                                  $caname = " (CA: {$ca['descr']})";
+                                  $selected = '';
+                                  if ($pconfig['crlref'] == $crl['refid']) {
+                                      $selected = 'selected="selected"';
+                                  }?>
+                            <option value="<?=htmlspecialchars($crl['refid']);?>" <?=$selected;?>><?=htmlspecialchars($crl['descr'] . $caname);?></option>
 <?php
+                              }
                           endforeach; ?>
                         </select>
 <?php