From cebee292d268425449a520ef99bf46bbffbcc3a2 Mon Sep 17 00:00:00 2001 From: Ad Schellevis Date: Thu, 20 Jan 2022 18:22:51 +0100 Subject: [PATCH] Services / Captiveportal - prevent session removal crashing out when we there's no IP address registered --- src/opnsense/scripts/OPNsense/CaptivePortal/disconnect.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/opnsense/scripts/OPNsense/CaptivePortal/disconnect.py b/src/opnsense/scripts/OPNsense/CaptivePortal/disconnect.py index 6bc167e83..d103a402a 100755 --- a/src/opnsense/scripts/OPNsense/CaptivePortal/disconnect.py +++ b/src/opnsense/scripts/OPNsense/CaptivePortal/disconnect.py @@ -49,7 +49,8 @@ if parameters['sessionid'] is not None and parameters['zoneid'] is not None: # remove client client_session_info = DB().del_client(parameters['zoneid'], parameters['sessionid']) if client_session_info is not None: - IPFW().delete(parameters['zoneid'], client_session_info['ip_address']) + if client_session_info['ip_address']: + IPFW().delete(parameters['zoneid'], client_session_info['ip_address']) client_session_info['terminateCause'] = 'User-Request' response = client_session_info