From cb8b83f56bb555a5a87376a4bb3b45c058138783 Mon Sep 17 00:00:00 2001 From: Ad Schellevis Date: Sun, 17 Mar 2019 18:35:00 +0100 Subject: [PATCH] Firewall, alias. proper locking before config action on delete --- .../app/controllers/OPNsense/Firewall/Api/AliasController.php | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/AliasController.php b/src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/AliasController.php index e07c64e8a..40dc558bc 100644 --- a/src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/AliasController.php +++ b/src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/AliasController.php @@ -30,8 +30,9 @@ namespace OPNsense\Firewall\Api; use \OPNsense\Base\ApiMutableModelControllerBase; -use \OPNsense\Core\Backend; use \OPNsense\Base\UserException; +use \OPNsense\Core\Backend; +use \OPNsense\Core\Config; /** * @package OPNsense\Firewall @@ -136,6 +137,7 @@ class AliasController extends ApiMutableModelControllerBase */ public function delItemAction($uuid) { + Config::getInstance()->lock(); $node = $this->getModel()->getNodeByReference('aliases.alias.'. $uuid); if ($node != null) { $uses = $this->getModel()->whereUsed((string)$node->name);