From c211858a08baa167a3a894ffdc3025e8bbdcd8d7 Mon Sep 17 00:00:00 2001 From: Stephan de Wit Date: Thu, 2 Nov 2023 13:57:31 +0100 Subject: [PATCH] MVC: config should be locked before calling checkAndThrowSafeDelete() --- .../controllers/OPNsense/Base/ApiMutableModelControllerBase.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/opnsense/mvc/app/controllers/OPNsense/Base/ApiMutableModelControllerBase.php b/src/opnsense/mvc/app/controllers/OPNsense/Base/ApiMutableModelControllerBase.php index d4769f19d..fcf76eef5 100644 --- a/src/opnsense/mvc/app/controllers/OPNsense/Base/ApiMutableModelControllerBase.php +++ b/src/opnsense/mvc/app/controllers/OPNsense/Base/ApiMutableModelControllerBase.php @@ -428,8 +428,8 @@ abstract class ApiMutableModelControllerBase extends ApiControllerBase $result = array("result" => "failed"); if ($this->request->isPost()) { - $this->checkAndThrowSafeDelete($uuid); Config::getInstance()->lock(); + $this->checkAndThrowSafeDelete($uuid); $mdl = $this->getModel(); if ($uuid != null) { $tmp = $mdl;