From c1c5ef115e29ff8fae5011bac83e07dd9880d2b8 Mon Sep 17 00:00:00 2001
From: framer99 <framer.ninety.nine@gmail.com>
Date: Fri, 28 Sep 2018 13:14:18 -0700
Subject: [PATCH] make Schedule icon reflect current schedule state

On firewall_rules.php, there is no indication whether a schedule-based
rule is active. This change to the schedule icon applies the same styles
that are applied to a disabled/enabled Pass rule icon (text-muted and
text-success).

The break added to the foreach loop is needed to retain reference to the
attached schedule for the filter_get_time_based_rule_status() call
---
 src/www/firewall_rules.php | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/src/www/firewall_rules.php b/src/www/firewall_rules.php
index 502250642..1e242d4f8 100644
--- a/src/www/firewall_rules.php
+++ b/src/www/firewall_rules.php
@@ -652,6 +652,7 @@ $( document ).ready(function() {
                                 if ($schedule['name'] == $filterent['sched'])
                                 {
                                     $schedule_descr = (isset($schedule['descr'])) ? $schedule['descr'] : "";
+                                    break;
                                 }
                             }
                         }
@@ -661,7 +662,14 @@ $( document ).ready(function() {
                         </span>
                         <a href="/firewall_schedule_edit.php?name=<?=htmlspecialchars($filterent['sched']);?>"
                             title="<?= html_safe(gettext('Edit')) ?>" data-toggle="tooltip">
-                          <i class="fa fa-calendar"></i>
+<?php
+                        if (filter_get_time_based_rule_status($schedule)):?>
+                          <i class="fa fa-calendar text-success"></i>
+<?php
+                        else:?>
+                          <i class="fa fa-calendar text-muted"></i>
+<?php
+                        endif;?>
                         </a>
 <?php
                        endif;?>