From c0cbbcc8e565b3bf41dd7177d299a327f8016bb0 Mon Sep 17 00:00:00 2001 From: Ad Schellevis Date: Wed, 1 Nov 2023 09:56:40 +0100 Subject: [PATCH] Gateways: Single: Migrate to MVC - Minor regression in first part of https://github.com/opnsense/core/pull/6808 if the gateway structure contains a as first element, technically speaking $config->gateways->gateway_item is empty. Better to check for children when gateway isn't empty to prevent none of the gateways being rendered in these cases. --- src/opnsense/mvc/app/models/OPNsense/Routing/Gateways.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/opnsense/mvc/app/models/OPNsense/Routing/Gateways.php b/src/opnsense/mvc/app/models/OPNsense/Routing/Gateways.php index 9834ec4c5..680483236 100644 --- a/src/opnsense/mvc/app/models/OPNsense/Routing/Gateways.php +++ b/src/opnsense/mvc/app/models/OPNsense/Routing/Gateways.php @@ -220,7 +220,7 @@ class Gateways extends BaseModel if ($use_legacy) { $config = Config::getInstance()->object(); - if (!empty($config->gateways) && !empty($config->gateways->gateway_item)) { + if (!empty($config->gateways) && count($config->gateways->children()) > 0) { foreach ($config->gateways->children() as $tag => $gateway) { if ($tag == 'gateway_item') { $record = [];