From bf79d5a625c9a8fc2da85f6d9d6b57d8dda33a1e Mon Sep 17 00:00:00 2001 From: pv2b Date: Thu, 11 Aug 2016 21:41:28 +0200 Subject: [PATCH] (base) Do not encourage overriding getModel() Overriding getModel() is not to be done lightly. The code relies on the same object being there through multiple calls to getModel(). Any overriding methods should preserve this same behavior. For this reason, we should not encourage tinkering with this in a comment, better be silent on the matter. --- .../controllers/OPNsense/Base/ApiMutableModelControllerBase.php | 1 - 1 file changed, 1 deletion(-) diff --git a/src/opnsense/mvc/app/controllers/OPNsense/Base/ApiMutableModelControllerBase.php b/src/opnsense/mvc/app/controllers/OPNsense/Base/ApiMutableModelControllerBase.php index 8f3b19e67..86823bdd5 100644 --- a/src/opnsense/mvc/app/controllers/OPNsense/Base/ApiMutableModelControllerBase.php +++ b/src/opnsense/mvc/app/controllers/OPNsense/Base/ApiMutableModelControllerBase.php @@ -95,7 +95,6 @@ abstract class ApiMutableModelControllerBase extends ApiControllerBase } /** - * override this to customize the model binding behavior * @return null|BaseModel */ protected function getModel()