From befa2aaceba9b7614a19a2272f2aaac42597d5f2 Mon Sep 17 00:00:00 2001
From: Franco Fichtner <franco@opnsense.org>
Date: Wed, 30 Aug 2023 12:47:24 +0200
Subject: [PATCH] interfaces: remove dead link/hint in gif table; closes #6799

While here let loop iterate over existing key (it's the same).
---
 src/www/interfaces_gif.php | 21 ++-------------------
 1 file changed, 2 insertions(+), 19 deletions(-)

diff --git a/src/www/interfaces_gif.php b/src/www/interfaces_gif.php
index d6669c6d9..58ecb7d81 100644
--- a/src/www/interfaces_gif.php
+++ b/src/www/interfaces_gif.php
@@ -111,9 +111,7 @@ legacy_html_escape_form_data($a_gifs);
                     </tr>
                   </thead>
                   <tbody>
-<?php
-                  $i = 0;
-                  foreach ($a_gifs as $gif): ?>
+<?php foreach ($a_gifs as $i => $gif): ?>
                     <tr>
                       <td><?= html_safe(convert_friendly_interface_to_friendly_descr(explode('_vip', $gif['if'])[0])) ?></td>
                       <td><?=$gif['remote-addr'];?></td>
@@ -127,22 +125,7 @@ legacy_html_escape_form_data($a_gifs);
                         </button>
                       </td>
                     </tr>
-<?php
-                  $i++;
-                  endforeach; ?>
-                    <tr>
-                      <td colspan="4">
-                        <?=sprintf(
-                          gettext(
-                            'If you are using a GIF tunnel to connect to a Hurricane Electric (he.net) Tunnel Broker ' .
-                            'on a WAN with a dynamic IP, you may want to add a %sHE.net Tunnelbroker dynamic DNS entry%s ' .
-                            'to keep your tunnel functional when your IP changes.'
-                          ),
-                          '<a href="services_dyndns.php">',
-                          '</a>'
-                        ); ?>
-                      </td>
-                    </tr>
+<?php endforeach ?>
                   </tbody>
                 </table>
               </div>