From beb63ec5bcde88c7e4514a64cbda0343ff638eea Mon Sep 17 00:00:00 2001
From: Franco Fichtner <franco@opnsense.org>
Date: Wed, 17 Nov 2021 13:32:29 +0100
Subject: [PATCH] firmware: make sure to emit status_reboot when no reboot
 takes place #5358

---
 .../app/controllers/OPNsense/Core/Api/FirmwareController.php  | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/opnsense/mvc/app/controllers/OPNsense/Core/Api/FirmwareController.php b/src/opnsense/mvc/app/controllers/OPNsense/Core/Api/FirmwareController.php
index 4407d4c52..4518c9daf 100644
--- a/src/opnsense/mvc/app/controllers/OPNsense/Core/Api/FirmwareController.php
+++ b/src/opnsense/mvc/app/controllers/OPNsense/Core/Api/FirmwareController.php
@@ -210,6 +210,7 @@ class FirmwareController extends ApiControllerBase
             $active_array = &$response['all_packages'];
             $active_size = $update_size;
             $active_status = 'update';
+            $active_reboot = '0';
 
             $sorted = [];
 
@@ -291,13 +292,14 @@ class FirmwareController extends ApiControllerBase
                     ($active_status == 'update' && $response['needs_reboot'] == 1) ||
                     ($active_status == 'upgrade' && $response['upgrade_needs_reboot'] == 1)
                 ) {
-                    $response['status_reboot'] = '1';
+                    $active_reboot = '1';
                     $response['status_msg'] = sprintf(
                         '%s %s',
                         $response['status_msg'],
                         gettext('This update requires a reboot.')
                     );
                 }
+                $response['status_reboot'] = $active_reboot;
                 $response['status'] = $active_status;
             } elseif (!$active_count) {
                 $response['status_msg'] = gettext('There are no updates available on the selected mirror.');