From bd984071b4faa2ed6d7ad7ccded12fb50d1ba358 Mon Sep 17 00:00:00 2001 From: Ad Schellevis Date: Sun, 29 Oct 2017 18:48:57 +0100 Subject: [PATCH] Firewall / Util, isAlias() should return false when an empty name is provided. for https://github.com/opnsense/core/issues/1903 --- src/opnsense/mvc/app/library/OPNsense/Firewall/Util.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/opnsense/mvc/app/library/OPNsense/Firewall/Util.php b/src/opnsense/mvc/app/library/OPNsense/Firewall/Util.php index fafce1f49..21877e964 100644 --- a/src/opnsense/mvc/app/library/OPNsense/Firewall/Util.php +++ b/src/opnsense/mvc/app/library/OPNsense/Firewall/Util.php @@ -75,7 +75,7 @@ class Util */ public static function isAlias($name) { - if (!empty(Config::getInstance()->object()->aliases)) { + if (!empty($name) && !empty(Config::getInstance()->object()->aliases)) { foreach (Config::getInstance()->object()->aliases->children() as $node) { if ($node->name == $name) { return true;