From bc392461da6e1fe79cd2aeb9c22214137f88906f Mon Sep 17 00:00:00 2001 From: Ad Schellevis Date: Fri, 12 Aug 2022 15:41:28 +0200 Subject: [PATCH] LDAP - PHP 8 issue when ldap_get_entries() returns false, for https://github.com/opnsense/core/issues/5949 --- src/opnsense/mvc/app/library/OPNsense/Auth/LDAP.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/opnsense/mvc/app/library/OPNsense/Auth/LDAP.php b/src/opnsense/mvc/app/library/OPNsense/Auth/LDAP.php index eda673619..dd702fec5 100644 --- a/src/opnsense/mvc/app/library/OPNsense/Auth/LDAP.php +++ b/src/opnsense/mvc/app/library/OPNsense/Auth/LDAP.php @@ -593,8 +593,8 @@ class LDAP extends Base implements IAuthConnector $this->lastAuthProperties['dn'] = $user_dn; if ($this->ldapReadProperties) { $sr = @ldap_read($this->ldapHandle, $user_dn, '(objectclass=*)', ['*', 'memberOf']); - $info = @ldap_get_entries($this->ldapHandle, $sr); - if ($info['count'] != 0) { + $info = $sr !== false ? @ldap_get_entries($this->ldapHandle, $sr) : []; + if (!empty($info['count'])) { foreach ($info[0] as $ldap_key => $ldap_value) { if (!is_numeric($ldap_key) && $ldap_key !== 'count') { if (isset($ldap_value['count'])) {