From bb4cddda35906a68e02eaf7b8b0af33bbef7038c Mon Sep 17 00:00:00 2001 From: Ad Schellevis Date: Fri, 8 Dec 2023 08:43:14 +0100 Subject: [PATCH] Firewall: Aliases - read before write in update_tables.py (minor stylefix) --- src/opnsense/scripts/filter/update_tables.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/opnsense/scripts/filter/update_tables.py b/src/opnsense/scripts/filter/update_tables.py index 2273b3f91..3e8db0dad 100755 --- a/src/opnsense/scripts/filter/update_tables.py +++ b/src/opnsense/scripts/filter/update_tables.py @@ -99,7 +99,7 @@ if __name__ == '__main__': alias_content_str = '\n'.join(sorted(alias_content)) if not os.path.isfile(alias_filename) or alias_content_str != alias.read_alias_file(alias_filename): # read before write, only save when the contents have changed - open('/var/db/aliastables/%s.txt' % alias_name, 'w').write(alias_content_str) + open(alias_filename, 'w').write(alias_content_str) # list current alias content when not trying to update a targetted list alias_pf_content = list(PF.list_table(alias_name)) if to_update is None else alias_content