diff --git a/src/www/firewall_schedule.php b/src/www/firewall_schedule.php
index 58313ed37..38f128763 100644
--- a/src/www/firewall_schedule.php
+++ b/src/www/firewall_schedule.php
@@ -217,7 +217,7 @@ legacy_html_escape_form_data($a_schedules);
}
}
$timeFriendly = $starttime . "-" . $stoptime;
- ?>
| =$dayFriendly;?> | =$timeFriendly;?> | =$timerange['rangedescr'];?> |
| =$dayFriendly;?> | =$timeFriendly;?> | = $timerange['rangedescr'] ?> |
diff --git a/src/www/firewall_schedule_edit.php b/src/www/firewall_schedule_edit.php
index 2e4350739..bbb4a03b5 100644
--- a/src/www/firewall_schedule_edit.php
+++ b/src/www/firewall_schedule_edit.php
@@ -600,40 +600,23 @@ function addTimeRange(){
}
function insertElements(label, start_hour, start_min, stop_hour, stop_min, description, days) {
+ const css = 'word-wrap: break-word; width: 100%; border: 0;';
+
+ const tr = $('
');
+ tr.append(`${label} | `);
+ tr.append(` | `);
+ tr.append(` | `);
+
+ const range_desc = $(``);
+ range_desc.val(description);
+ $(' | ').append(range_desc).appendTo(tr);
+
+ tr.append(` | `);
+ tr.append(` | `);
+ tr.append(` | `);
+
//add it to the schedule list
- let d = document;
- let tbody = document.getElementById("scheduletable").getElementsByTagName("tbody").item(0);
- var tr = document.createElement("tr");
- var td = document.createElement("td");
- td.innerHTML= ""+label+"";
- tr.appendChild(td);
-
- td = document.createElement("td");
- td.innerHTML="";
- tr.appendChild(td);
-
- td = document.createElement("td");
- td.innerHTML="";
- tr.appendChild(td);
-
- td = $("");
- td.val(description);
- tr.appendChild(td[0]);
-
- td = document.createElement("td");
- td.innerHTML = ``;
- tr.appendChild(td);
-
- td = document.createElement("td");
- td.innerHTML = "";
- tr.appendChild(td);
-
- td = document.createElement("td");
- td.innerHTML="";
- tr.appendChild(td);
- tbody.appendChild(tr);
-
- schCounter++;
+ $('#scheduletable tbody').append(tr);
//reset calendar and time and descr
clearCalendar();
@@ -641,7 +624,6 @@ function insertElements(label, start_hour, start_min, stop_hour, stop_min, descr
clearDescr();
}
-
function clearCalendar(){
var tempstr, daycell = "";
//clear days selected
@@ -676,26 +658,27 @@ function clearDescr(){
$('#timerangedescr').val('');
}
-function editRow(el, days, start_time, stop_time, seq) {
+function editRow(row_num) {
if (!checkForRanges())
- return;
+ return false;
//reset calendar and time
clearCalendar();
clearTime();
let start_hour, start_min, stop_hour, stop_min;
- [start_hour, start_min] = start_time.split(':');
- [stop_hour, stop_min] = stop_time.split(':');
-
+ [start_hour, start_min] = $(`#starttime${row_num}`).val().split(':');
+ [stop_hour, stop_min] = $(`#stoptime${row_num}`).val().split(':');
$('#starttimehour').selectpicker('val', start_hour);
$('#starttimemin').selectpicker('val', start_min);
$('#stoptimehour').selectpicker('val', stop_hour);
$('#stoptimemin').selectpicker('val', stop_min);
- $('#timerangedescr').val($("#timedescr"+seq).val());
+ $('#timerangedescr').val($(`#timedescr${row_num}`).val());
+ let days = $(`#schedule${row_num}`).val();
let first_selected_month = days.search('m');
+
if (first_selected_month !== -1) {
first_selected_month = days.substring(first_selected_month);
first_selected_month = first_selected_month.split('d')[0].slice(1);
@@ -719,32 +702,25 @@ function editRow(el, days, start_time, stop_time, seq) {
daytoggle(day);
});
- removeRownoprompt(el);
+ return removeRownoprompt.bind(this)();
}
-function removeRownoprompt(el) {
- while (el && el.nodeName.toLowerCase() != "tr") {
- el = el.parentNode;
- }
- if (el) {
- el.remove();
- }
+function removeRownoprompt() {
+ $(this).closest('tr').remove();
+ return false;
}
+function removeRow() {
+ if (!confirm("Do you really want to delete this time range?"))
+ return false;
-function removeRow(el) {
- if (confirm("Do you really want to delete this time range?")){
- while (el && el.nodeName.toLowerCase() != "tr") {
- el = el.parentNode;
- }
- if (el) {
- el.remove();
- }
- }
+ return removeRownoprompt.bind(this)();
}
-// XXX Workaround: hook_stacked_form_tables breaks CSS query otherwise
-$( function() { $('#iform td').css({ 'background-color' : '' }); })
+$(function() {
+ // XXX Workaround: hook_stacked_form_tables breaks CSS query otherwise
+ $('#iform td').css({ 'background-color' : '' });
+});
//]]>
@@ -985,6 +961,7 @@ $( function() { $('#iform td').css({ 'background-color' : '' }); })
$dayFriendly = "";
$tempFriendlyTime = "";
$timedescr = $timerange['rangedescr'];
+
//get hours
$temptimerange = $timerange['hour'];
$temptimeseparator = strrpos($temptimerange, "-");
@@ -1090,19 +1067,19 @@ $( function() { $('#iform td').css({ 'background-color' : '' }); })
=$tempFriendlyTime; ?>
-
+
|
-
+
|
-
+
|
-
+
|
-
+
|
|