From b5fcded52f8ccc16b7d79ca08f49eb19eabc3c24 Mon Sep 17 00:00:00 2001
From: Ad Schellevis <ad@opnsense.org>
Date: Mon, 22 Mar 2021 13:29:18 +0100
Subject: [PATCH] Services / DHCPv4: with the removal of a validation for
 static entries in https://github.com/opnsense/core/pull/4447 forgot to check
 the dhcp settings page for additional ones. closes
 https://github.com/opnsense/core/issues/4855

---
 src/www/services_dhcp.php | 13 -------------
 1 file changed, 13 deletions(-)

diff --git a/src/www/services_dhcp.php b/src/www/services_dhcp.php
index 88c0a79a6..577d107b4 100644
--- a/src/www/services_dhcp.php
+++ b/src/www/services_dhcp.php
@@ -383,19 +383,6 @@ if ($_SERVER['REQUEST_METHOD'] === 'GET') {
                 $input_errors[] = sprintf(gettext("You must disable the DHCP relay on the %s interface before enabling the DHCP server."),
                                   !empty($config['interfaces'][$if]['descr']) ? htmlspecialchars($config['interfaces'][$if]['descr']) : strtoupper($if));
             }
-
-            $dynsubnet_start = ip2ulong($pconfig['range_from']);
-            $dynsubnet_end = ip2ulong($pconfig['range_to']);
-            foreach ($a_maps as $map) {
-                if (empty($map['ipaddr'])) {
-                    continue;
-                }
-                if ((ip2ulong($map['ipaddr']) > $dynsubnet_start) &&
-                  (ip2ulong($map['ipaddr']) < $dynsubnet_end)) {
-                    $input_errors[] = sprintf(gettext("The DHCP range cannot overlap any static DHCP mappings."));
-                    break;
-                }
-            }
         }
         // save data
         if (count($input_errors) == 0) {