lucaspalomodevelop/core
1
0
Fork 0
mirror of https://github.com/lucaspalomodevelop/core.git synced 2026-03-13 16:14:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

Interfaces: Virtual IPs: Settings - fix config locking when deleting a node.

Browse Source 
This is a bit of a tricky one, delBase() always locks, which enforces the proper sequence in concurrent operations, but when reading the config first with getModel(), we are locking the wrong state (memory doesn't equal disk anymore).
This commit is contained in:
Ad Schellevis 2023-10-24 10:11:47 +02:00
parent b0f3e131f5
commit ad2e5e7515
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/opnsense/mvc/app/controllers/OPNsense/Interfaces/Api/VipSettingsController.php
View File

@ -176,6 +176,7 @@ class VipSettingsController extends ApiMutableModelControllerBase
public function delItemAction($uuid)
{
Config::getInstance()->lock();
$node = $this->getModel()->getNodeByReference('vip.' . $uuid);
$validations = $this->getModel()->whereUsed((string)$node->subnet);
if (!empty($validations)) {