From ab3bf029cac6dfdba88fee3a6cabea565bc310b9 Mon Sep 17 00:00:00 2001
From: Franco Fichtner <franco@opnsense.org>
Date: Sun, 1 Sep 2024 10:51:23 +0200
Subject: [PATCH] interfaces: another cleanup

---
 src/opnsense/scripts/interfaces/reconfigure_vips.php | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/src/opnsense/scripts/interfaces/reconfigure_vips.php b/src/opnsense/scripts/interfaces/reconfigure_vips.php
index a67eb35f2..74513b981 100755
--- a/src/opnsense/scripts/interfaces/reconfigure_vips.php
+++ b/src/opnsense/scripts/interfaces/reconfigure_vips.php
@@ -33,7 +33,8 @@ require_once("interfaces.inc");
 require_once("util.inc");
 
 $addresses = [];
-$anyproxyarp = false;
+$proxyarp = false;
+
 foreach (legacy_interfaces_details() as $ifname => $ifcnf) {
     foreach (['ipv4', 'ipv6'] as $proto) {
         if (!empty($ifcnf[$proto])) {
@@ -79,7 +80,7 @@ foreach (glob("/tmp/delete_vip_*.todo") as $filename) {
             legacy_interface_deladdress($addresses[$address]['if'], $address, is_ipaddrv6($address) ? 6 : 4);
         } else {
             // not found, likely proxy arp
-            $anyproxyarp = true;
+            $proxyarp = true;
         }
     }
     unlink($filename);
@@ -107,7 +108,7 @@ if (!empty($config['virtualip']['vip'])) {
             $peer = !empty($vipent['peer']) ? $vipent['peer'] : '224.0.0.18';
             $peer6 = !empty($vipent['peer6']) ? $vipent['peer6'] : 'ff02::12';
             if ($vipent['mode'] == 'proxyarp') {
-                $anyproxyarp = true;
+                $proxyarp = true;
             }
             if (in_array($vipent['mode'], ['proxyarp', 'other'])) {
                 if (isset($addresses[$subnet])) {
@@ -149,6 +150,6 @@ if (!empty($config['virtualip']['vip'])) {
     }
 }
 
-if ($anyproxyarp) {
+if ($proxyarp) {
     interface_proxyarp_configure();
 }