From a9d00046ff1a45f7869e6424445b94c5f2d596c9 Mon Sep 17 00:00:00 2001
From: Franco Fichtner <franco@opnsense.org>
Date: Thu, 11 Feb 2021 10:37:44 +0100
Subject: [PATCH] firmware: check status instead of using fail #4500

Also back off a little when not getting proper data.
---
 src/opnsense/mvc/app/views/OPNsense/Core/firmware.volt | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/src/opnsense/mvc/app/views/OPNsense/Core/firmware.volt b/src/opnsense/mvc/app/views/OPNsense/Core/firmware.volt
index 6f9bcb9a2..cd8ae54ca 100644
--- a/src/opnsense/mvc/app/views/OPNsense/Core/firmware.volt
+++ b/src/opnsense/mvc/app/views/OPNsense/Core/firmware.volt
@@ -305,6 +305,11 @@
      */
     function trackStatus() {
         ajaxGet('/api/core/firmware/upgradestatus', {}, function(data, status) {
+           if (status != 'success') {
+                // recover from temporary errors
+                setTimeout(trackStatus, 1000);
+                return;
+            }
             if (data['log'] != undefined && data['log'] != '') {
                 var autoscroll = $('#update_status')[0].scrollTop +
                     $('#update_status')[0].clientHeight ===
@@ -344,9 +349,6 @@
                 // schedule next poll
                 setTimeout(trackStatus, 500);
             }
-        }).fail(function () {
-            // recover from temporary errors
-            setTimeout(trackStatus, 500);
         });
     }