firewall, plugin. move parseIsComment to abstract class for reuse

src/opnsense/mvc/app/library/OPNsense/Firewall/FilterRule.php

@@ -65,16 +65,6 @@ class FilterRule extends Rule
         'label' => 'parsePlain,label ",",63'
     );
 
-    /**
-     * output parsing
-     * @param string $value field value
-     * @return string
-     */
-    private function parseIsComment($value)
-    {
-        return !empty($value) ? "#" : "";
-    }
-
     /**
      * parse plain data
      * @param string $value field value

src/opnsense/mvc/app/library/OPNsense/Firewall/Rule.php

@@ -50,6 +50,16 @@ abstract class Rule
         $this->rule = $conf;
     }
 
+    /**
+     * output parsing
+     * @param string $value field value
+     * @return string
+     */
+    protected function parseIsComment($value)
+    {
+        return !empty($value) ? "#" : "";
+    }
+
     /**
      * convert source/destination address entries as used by the gui
      * @param array $rule rule