diff --git a/src/etc/inc/interfaces.inc b/src/etc/inc/interfaces.inc index 713429875..bbe84dba6 100644 --- a/src/etc/inc/interfaces.inc +++ b/src/etc/inc/interfaces.inc @@ -1785,7 +1785,7 @@ function interface_sync_wireless_clones(&$ifcfg, $sync_changes = false) $baseif = interface_get_wireless_base($ifcfg['if']); - foreach (get_configured_interface_with_descr(false, true) as $if => $unused) { + foreach (get_configured_interface_with_descr(true) as $if => $unused) { if ($baseif == interface_get_wireless_base($config['interfaces'][$if]['if']) && $ifcfg['if'] != $config['interfaces'][$if]['if']) { if (isset($config['interfaces'][$if]['wireless']['standard']) || $sync_changes) { foreach ($shared_settings as $setting) { @@ -3513,7 +3513,7 @@ function convert_friendly_interface_to_friendly_descr($interface) } } } else { - foreach (get_configured_interface_with_descr(false, true) as $if => $ifname) { + foreach (get_configured_interface_with_descr(true) as $if => $ifname) { if ($if == $interface || $ifname == $interface) { return $ifname; } diff --git a/src/etc/inc/util.inc b/src/etc/inc/util.inc index a9460af9a..2f548a289 100644 --- a/src/etc/inc/util.inc +++ b/src/etc/inc/util.inc @@ -749,15 +749,11 @@ function get_configured_vips_list() return $alias_list; } -function get_configured_interface_with_descr($only_opt = false, $withdisabled = false) +function get_configured_interface_with_descr($withdisabled = false) { $iflist = array(); foreach (legacy_config_get_interfaces(array('virtual' => false)) as $if => $ifdetail) { - if ($only_opt && ($if == 'wan' || $if == 'lan')) { - continue; - } - if (isset($ifdetail['enable']) || $withdisabled == true) { $iflist[$if] = $ifdetail['descr']; } diff --git a/src/opnsense/scripts/shell/banner.php b/src/opnsense/scripts/shell/banner.php index 0b0c14de5..01b29bdf4 100755 --- a/src/opnsense/scripts/shell/banner.php +++ b/src/opnsense/scripts/shell/banner.php @@ -43,7 +43,7 @@ $product = $g['product_name']; echo "\n*** {$hostname}.{$domain}: {$product} {$version} ({$machine}/${flavour}) ***\n"; -$iflist = get_configured_interface_with_descr(false, true); +$iflist = get_configured_interface_with_descr(true); if (empty($iflist)) { echo "\n\tNo network interfaces are assigned.\n"; diff --git a/src/opnsense/scripts/shell/setaddr.php b/src/opnsense/scripts/shell/setaddr.php index ca3d3504c..4f5782221 100755 --- a/src/opnsense/scripts/shell/setaddr.php +++ b/src/opnsense/scripts/shell/setaddr.php @@ -135,7 +135,7 @@ function get_interface_config_description($iface) $fp = fopen('php://stdin', 'r'); /* build an interface collection */ -$ifdescrs = get_configured_interface_with_descr(false, true); +$ifdescrs = get_configured_interface_with_descr(true); $count = count($ifdescrs); /* grab interface that we will operate on, unless there is only one diff --git a/src/www/firewall_virtual_ip.php b/src/www/firewall_virtual_ip.php index aa62834d3..a45995060 100644 --- a/src/www/firewall_virtual_ip.php +++ b/src/www/firewall_virtual_ip.php @@ -267,7 +267,7 @@ $main_buttons = array(