From 9da1b92e268673b5b6c7737608ac425c18c22349 Mon Sep 17 00:00:00 2001
From: Ad Schellevis <ad@opnsense.org>
Date: Fri, 11 Mar 2016 13:04:36 +0100
Subject: [PATCH] services_dyndns_edit: wrong parameter type for
 htmlspecialchars, closes https://github.com/opnsense/core/issues/813

---
 src/www/services_dyndns_edit.php | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/www/services_dyndns_edit.php b/src/www/services_dyndns_edit.php
index 969fa10b2..346c488c9 100644
--- a/src/www/services_dyndns_edit.php
+++ b/src/www/services_dyndns_edit.php
@@ -262,7 +262,7 @@ include("head.inc");
                         $iflist = array_merge($iflist, return_gateway_groups_array());
                         foreach ($iflist as $if => $ifdesc):?>
                           <option value="<?=$if;?>" <?=$pconfig['interface'] == $if ? "selected=\"selected\"" : "";?>>
-                            <?=htmlspecialchars($ifdesc);?>
+                            <?=is_array($ifdesc) ? $if : htmlspecialchars($ifdesc);?>
                           </option>
 
 <?php
@@ -279,7 +279,7 @@ include("head.inc");
                        $iflist = array_merge($iflist, return_gateway_groups_array());
                        foreach ($iflist as $if => $ifdesc):?>
                          <option value="<?=$if;?>" <?=$pconfig['requestif'] == $if ? "selected=\"selected\"" : "";?>>
-                           <?=htmlspecialchars($ifdesc);?>
+                           <?=is_array($ifdesc) ? $if : htmlspecialchars($ifdesc);?>
                          </option>
 
 <?php