From 9cb123ce7f625ada94a4ec88ae3eee703452deca Mon Sep 17 00:00:00 2001
From: Franco Fichtner <franco@opnsense.org>
Date: Fri, 22 Sep 2023 10:25:21 +0200
Subject: [PATCH] interfaces: fix a PHP warning and make a comment about
 floating rules

---
 src/www/interfaces_assign.php | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/www/interfaces_assign.php b/src/www/interfaces_assign.php
index 754565f32..10b15aa71 100644
--- a/src/www/interfaces_assign.php
+++ b/src/www/interfaces_assign.php
@@ -172,7 +172,8 @@ if ($_SERVER['REQUEST_METHOD'] === 'POST') {
 
             if (isset($config['filter']['rule'])) {
                 foreach ($config['filter']['rule'] as $x => $rule) {
-                    if ($rule['interface'] == $id) {
+                    /* XXX this doesn't match floating rules with multiple values */
+                    if (isset($rule['interface']) && $rule['interface'] == $id) {
                         unset($config['filter']['rule'][$x]);
                     }
                 }