Firewall: Aliases - when using port type aliases the "enable" flag was ignored. closes https://github.com/opnsense/core/issues/5594

missed the rule part preventing empty port tables from being used in previous commit
This commit is contained in:
Ad Schellevis 2022-02-23 10:34:04 +01:00
parent 61445fc13d
commit 99c70a538a

View File

@ -671,7 +671,11 @@ function filter_generate_aliases()
file_notice(sprintf(gettext('URL port aliases types not supported [%s]'), $aliased['name']));
break;
case "port":
$tmp_ports = implode(" ", filter_core_get_port_alias($aliased['name'], array(), $aliasObject));
$tmp_ports = implode(" ", filter_core_get_port_alias($aliased['name'], [], $aliasObject));
if (empty($tmp_ports)) {
// we can't create empty port tables, so when it's empty we should make sure it can't match
$tmp_ports = "0 <> 65535";
}
$aliases .= "{$aliased['name']} = \"{ {$tmp_ports} }\"\n";
break;
default: