From 9927f3d49af512ea121d677477abfb129f38f240 Mon Sep 17 00:00:00 2001 From: Bi0T1N <28802083+Bi0T1N@users.noreply.github.com> Date: Sat, 15 Apr 2023 16:31:40 +0200 Subject: [PATCH] proxy: allow more signs for username and password (#6477) - eliminate the artificial limit of length and signs which does not exist in squid - allow in particular @ to support first.last@mycompany.com as username - all other characters can be used via URL escaping (i.e. %20 for spaces) but this also means % must be written as %% see http://www.squid-cache.org/Doc/config/cache_peer/ Co-authored-by: Bi0T1N --- src/opnsense/mvc/app/models/OPNsense/Proxy/Proxy.xml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/opnsense/mvc/app/models/OPNsense/Proxy/Proxy.xml b/src/opnsense/mvc/app/models/OPNsense/Proxy/Proxy.xml index f8bee385e..65a9f0f13 100644 --- a/src/opnsense/mvc/app/models/OPNsense/Proxy/Proxy.xml +++ b/src/opnsense/mvc/app/models/OPNsense/Proxy/Proxy.xml @@ -1,6 +1,6 @@ //OPNsense/proxy - 1.0.5 + 1.0.6 (squid) proxy settings @@ -243,14 +243,14 @@ username Y - /^([0-9a-zA-Z\._\-]){1,32}$/u - Username can be up to 32 signs long. Alphanumeric characters and also dot, dash and underscore allowed. + /^([0-9a-zA-Z\._\-%@]){1,128}$/u + Username can be up to 128 signs long. Alphanumeric characters and also dot, dash, percent sign (for URL escapes), at sign and underscore allowed. password Y - /^([0-9a-zA-Z\._\-]){1,32}$/u - Password can be up to 32 signs long. Alphanumeric characters and also dot, dash and underscore allowed. + /^([0-9a-zA-Z\._\-%]){1,128}$/u + Password can be up to 128 signs long. Alphanumeric characters and also dot, dash, percent sign (for URL escapes) and underscore allowed. N