From 9422d6435e48b099dab92448c437caf3043a7888 Mon Sep 17 00:00:00 2001
From: Franco Fichtner <franco@opnsense.org>
Date: Tue, 17 Sep 2024 08:30:08 +0200
Subject: [PATCH] system: kill these dashboard-only entries

They are already disabled and do exist elsewhere. lint-acl doesn't
complain either and now the risk of false positives is zero.
---
 .../mvc/app/models/OPNsense/Core/ACL/ACL.xml  | 70 -------------------
 1 file changed, 70 deletions(-)

diff --git a/src/opnsense/mvc/app/models/OPNsense/Core/ACL/ACL.xml b/src/opnsense/mvc/app/models/OPNsense/Core/ACL/ACL.xml
index 5867e36a0..1b805eee1 100644
--- a/src/opnsense/mvc/app/models/OPNsense/Core/ACL/ACL.xml
+++ b/src/opnsense/mvc/app/models/OPNsense/Core/ACL/ACL.xml
@@ -78,76 +78,6 @@
             <pattern>api/ipsec/sessions/*</pattern>
         </patterns>
     </page-dashboard-all>
-    <!--
-    Below are some sidgets that don't fully belong to existing components, if anyone asks to grant access
-    to specific users for these, it might be better to debate what is really needed besides the existing
-    dashboard-all role (e.g. dasboard-informational as role to goup these might also work for example).
-
-     <page-dashboard-widget-system-information>
-        <name>Dashboard: System Information widget</name>
-        <patterns>
-            <pattern>ui/core/dashboard</pattern>
-            <pattern>api/core/dashboard/*</pattern>
-            <pattern>api/diagnostics/system/systemInformation</pattern>
-            <pattern>api/diagnostics/system/systemTime</pattern>
-        </patterns>
-    </page-dashboard-widget-system-information>
-    <page-dashboard-widget-cpu>
-        <name>Dashboard: CPU Usage widget</name>
-        <patterns>
-            <pattern>ui/core/dashboard</pattern>
-            <pattern>api/core/dashboard/*</pattern>
-            <pattern>api/diagnostics/cpu_usage/*</pattern>
-        </patterns>
-    </page-dashboard-widget-cpu>
-    <page-dashboard-widget-disk>
-        <name>Dashboard: Disk Usage widget</name>
-        <patterns>
-            <pattern>ui/core/dashboard</pattern>
-            <pattern>api/core/dashboard/*</pattern>
-            <pattern>api/core/system/systemDisk</pattern>
-        </patterns>
-    </page-dashboard-widget-disk>
-    <page-dashboard-widget-firewallstates>
-        <name>Dashboard: Firewall States Usage widget</name>
-        <patterns>
-            <pattern>ui/core/dashboard</pattern>
-            <pattern>api/core/dashboard/*</pattern>
-            <pattern>api/diagnostics/firewall/pf_states</pattern>
-        </patterns>
-    </page-dashboard-widget-firewallstates>
-    <page-dashboard-widget-mbuf>
-        <name>Dashboard: Mbuf Usage widget</name>
-        <patterns>
-            <pattern>ui/core/dashboard</pattern>
-            <pattern>api/core/dashboard/*</pattern>
-            <pattern>api/core/system/system_mbuf</pattern>
-        </patterns>
-    </page-dashboard-widget-mbuf>
-    <page-dashboard-widget-memory>
-        <name>Dashboard: Memory Usage widget</name>
-        <patterns>
-            <pattern>ui/core/dashboard</pattern>
-            <pattern>api/core/dashboard/*</pattern>
-            <pattern>api/core/system/systemResources</pattern>
-        </patterns>
-    </page-dashboard-widget-memory>
-    <page-dashboard-widget-swap>
-        <name>Dashboard: Swap Usage widget</name>
-        <patterns>
-            <pattern>ui/core/dashboard</pattern>
-            <pattern>api/core/dashboard/*</pattern>
-            <pattern>api/core/system/system_swap</pattern>
-        </patterns>
-    </page-dashboard-widget-swap>
-    <page-dashboard-widget-thermal-sensors>
-        <name>Dashboard: Thermal Sensors widget</name>
-        <patterns>
-            <pattern>ui/core/dashboard</pattern>
-            <pattern>api/core/dashboard/*</pattern>
-            <pattern>api/core/system/systemTemperature</pattern>
-        </patterns>
-    </page-dashboard-widget-thermal-sensors> -->
     <page-diagnostics-authentication>
         <name>Diagnostics: Authentication</name>
         <patterns>