diff --git a/plist b/plist index e4b88e017..5df946dcf 100644 --- a/plist +++ b/plist @@ -553,6 +553,7 @@ /usr/local/opnsense/mvc/app/models/OPNsense/Core/Firmware.xml /usr/local/opnsense/mvc/app/models/OPNsense/Core/Menu/Menu.xml /usr/local/opnsense/mvc/app/models/OPNsense/Core/Migrations/M1_0_0.php +/usr/local/opnsense/mvc/app/models/OPNsense/Core/Migrations/M1_0_1.php /usr/local/opnsense/mvc/app/models/OPNsense/Cron/ACL/ACL.xml /usr/local/opnsense/mvc/app/models/OPNsense/Cron/Cron.php /usr/local/opnsense/mvc/app/models/OPNsense/Cron/Cron.xml diff --git a/src/opnsense/mvc/app/controllers/OPNsense/Core/Api/FirmwareController.php b/src/opnsense/mvc/app/controllers/OPNsense/Core/Api/FirmwareController.php index e492eb849..e637cf883 100644 --- a/src/opnsense/mvc/app/controllers/OPNsense/Core/Api/FirmwareController.php +++ b/src/opnsense/mvc/app/controllers/OPNsense/Core/Api/FirmwareController.php @@ -857,7 +857,7 @@ class FirmwareController extends ApiControllerBase /* package infos are flat lists with 3 pipes as delimiter */ foreach (array('remote', 'local') as $type) { $current = $backend->configdRun("firmware ${type}"); - $current = explode("\n", trim($current)); + $current = explode("\n", trim($current ?? '')); foreach ($current as $line) { $expanded = explode('|||', $line); diff --git a/src/opnsense/mvc/app/controllers/OPNsense/Core/Api/repositories/opnsense.xml b/src/opnsense/mvc/app/controllers/OPNsense/Core/Api/repositories/opnsense.xml index 621facd62..83ddda9f8 100644 --- a/src/opnsense/mvc/app/controllers/OPNsense/Core/Api/repositories/opnsense.xml +++ b/src/opnsense/mvc/app/controllers/OPNsense/Core/Api/repositories/opnsense.xml @@ -98,14 +98,10 @@ - + (default) - - latest - OpenSSL - diff --git a/src/opnsense/mvc/app/models/OPNsense/Core/Firmware.xml b/src/opnsense/mvc/app/models/OPNsense/Core/Firmware.xml index ac570ebfc..10dc248a7 100644 --- a/src/opnsense/mvc/app/models/OPNsense/Core/Firmware.xml +++ b/src/opnsense/mvc/app/models/OPNsense/Core/Firmware.xml @@ -1,6 +1,6 @@ //system/firmware - 1.0.0 + 1.0.1 OPNsense Firmware settings diff --git a/src/opnsense/mvc/app/models/OPNsense/Core/Migrations/M1_0_0.php b/src/opnsense/mvc/app/models/OPNsense/Core/Migrations/M1_0_0.php index fd6be5729..9d7a610c5 100644 --- a/src/opnsense/mvc/app/models/OPNsense/Core/Migrations/M1_0_0.php +++ b/src/opnsense/mvc/app/models/OPNsense/Core/Migrations/M1_0_0.php @@ -1,31 +1,29 @@ type) || (string)$model->type == "devel") && !empty((string)$model->mirror)) { - $is_business = stripos((string)$model->mirror, "opnsense-update.deciso.com") > 1; + if ((empty((string)$model->type) || (string)$model->type == 'devel') && !empty((string)$model->mirror)) { + $is_business = stripos((string)$model->mirror, 'opnsense-update.deciso.com') > 1; if ($is_business) { - $model->type = "business"; - $model->flavour = "latest"; + $model->type = 'business'; + $model->flavour = 'latest'; } } } diff --git a/src/opnsense/mvc/app/models/OPNsense/Core/Migrations/M1_0_1.php b/src/opnsense/mvc/app/models/OPNsense/Core/Migrations/M1_0_1.php new file mode 100644 index 000000000..38f410ee9 --- /dev/null +++ b/src/opnsense/mvc/app/models/OPNsense/Core/Migrations/M1_0_1.php @@ -0,0 +1,45 @@ +flavour, ['latest', 'libressl'])) { + $model->flavour = null; + } + } +} diff --git a/src/opnsense/mvc/app/views/OPNsense/Core/firmware.volt b/src/opnsense/mvc/app/views/OPNsense/Core/firmware.volt index ac3687606..4d8dcdb34 100644 --- a/src/opnsense/mvc/app/views/OPNsense/Core/firmware.volt +++ b/src/opnsense/mvc/app/views/OPNsense/Core/firmware.volt @@ -655,12 +655,12 @@ // handle firmware config options ajaxGet('/api/core/firmware/getFirmwareOptions', {}, function(firmwareoptions, status) { ajaxGet('/api/core/firmware/getFirmwareConfig', {}, function(firmwareconfig, status) { - var other_selected = true; + var custom_selected = true; $.each(firmwareoptions.mirrors, function(key, value) { var selected = false; if ((key != "" && firmwareconfig['mirror'].indexOf(key) != -1) || key == firmwareconfig['mirror']) { selected = true; - other_selected = false; + custom_selected = false; } $("#firmware_mirror").append($("") .attr("value",key) @@ -670,11 +670,11 @@ ); }); if (firmwareoptions['mirrors_allow_custom']) { - $("#firmware_mirror").prepend($("") + $("#firmware_mirror :first-child").after($("") .attr("value", firmwareconfig['mirror']) - .text("(other)") - .data("other", 1) - .prop('selected', other_selected) + .text("(custom)") + .data("custom", 1) + .prop('selected', custom_selected) ); } @@ -687,12 +687,12 @@ $("#firmware_mirror").selectpicker('refresh'); $("#firmware_mirror").change(); - other_selected = true; + custom_selected = true; $.each(firmwareoptions.flavours, function(key, value) { var selected = false; if (key == firmwareconfig['flavour']) { selected = true; - other_selected = false; + custom_selected = false; } $("#firmware_flavour").append($("") .attr("value",key) @@ -701,11 +701,11 @@ ); }); if (firmwareoptions['flavours_allow_custom']) { - $("#firmware_flavour").prepend($("") + $("#firmware_flavour :first-child").after($("") .attr("value", firmwareconfig['flavour']) - .text("(other)") - .data("other", 1) - .prop('selected', other_selected) + .text("(custom)") + .data("custom", 1) + .prop('selected', custom_selected) ); } $("#firmware_flavour").selectpicker('refresh'); @@ -729,18 +729,18 @@ $("#firmware_mirror").change(function(){ $("#firmware_mirror_value").val($(this).val()); - if ($(this).find(':selected').data("other") == 1) { - $("#firmware_mirror_other").show(); + if ($(this).find(':selected').data("custom") == 1) { + $("#firmware_mirror_custom").show(); } else { - $("#firmware_mirror_other").hide(); + $("#firmware_mirror_custom").hide(); } }); $("#firmware_flavour").change(function() { $("#firmware_flavour_value").val($(this).val()); - if ($(this).find(':selected').data("other") == 1) { - $("#firmware_flavour_other").show(); + if ($(this).find(':selected').data("custom") == 1) { + $("#firmware_flavour_custom").show(); } else { - $("#firmware_flavour_other").hide(); + $("#firmware_flavour_custom").hide(); } }); @@ -975,7 +975,7 @@ - + @@ -990,11 +990,11 @@ - + - {{ lang._('Select the firmware cryptography flavour.') }} + {{ lang._('Select an alternate firmware flavour.') }}