From 90c0c395a54967f28c797b46293d4fb975b27ded Mon Sep 17 00:00:00 2001
From: Franco Fichtner <franco@opnsense.org>
Date: Fri, 15 Feb 2019 11:26:14 +0100
Subject: [PATCH] interfaces: check for valid alias IP #3197

Suggested by: @tbandixen
---
 src/opnsense/scripts/interfaces/dhclient-script | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/opnsense/scripts/interfaces/dhclient-script b/src/opnsense/scripts/interfaces/dhclient-script
index 99387429f..c9c772db9 100755
--- a/src/opnsense/scripts/interfaces/dhclient-script
+++ b/src/opnsense/scripts/interfaces/dhclient-script
@@ -349,7 +349,7 @@ BOUND|RENEW|REBIND|REBOOT)
 		delete_old_states
 	fi
 	if [ -n "$old_ip_address" ]; then
-		if [ "$old_ip_address" != "$alias_ip_address" ]; then
+		if [ -n "$alias_ip_address" -a "$old_ip_address" != "$alias_ip_address" ]; then
 			delete_old_alias
 			changes="yes"
 		fi
@@ -367,7 +367,7 @@ BOUND|RENEW|REBIND|REBOOT)
 		add_new_routes
 		changes="yes"
 	fi
-	if [ "$new_ip_address" != "$alias_ip_address" ]; then
+	if [ -n "$alias_ip_address" -a "$new_ip_address" != "$alias_ip_address" ]; then
 		add_new_alias
 		changes="yes"
 	fi